Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deeper chunking of node stats response #93985

Closed
DaveCTurner opened this issue Feb 21, 2023 · 1 comment · Fixed by #95060
Closed

Deeper chunking of node stats response #93985

DaveCTurner opened this issue Feb 21, 2023 · 1 comment · Fixed by #95060
Labels
>bug :Data Management/Stats Statistics tracking and retrieval APIs Team:Data Management Meta label for data/management team

Comments

@DaveCTurner
Copy link
Contributor

Today the node stats response emits per-node chunks, but with ?level=indices or ?level=shards these chunks can still be very large. When #90097 was opened this was the best we could do, but #91771 means we can now make different chunking decisions based on the response parameters, so we should use this to break the per-node chunks up into smaller pieces as needed.

Relates #89838
@DaveCTurner DaveCTurner added >bug :Data Management/Stats Statistics tracking and retrieval APIs labels Feb 21, 2023
@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Feb 21, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this issue Apr 5, 2023
@DaveCTurner
Deeper chunking of node stats response
e421115 
Pushes the chunking of `GET _nodes/stats` down to avoid creating
unboundedly large chunks. With this commit we yield one chunk per shard
(if `?level=shards`) or index (if `?level=indices`) and per HTTP client
and per transport action.

Closes elastic#93985
This was referenced Apr 5, 2023
Merged
Open
elasticsearchmachine pushed a commit that referenced this issue Apr 6, 2023
@DaveCTurner
Deeper chunking of node stats response (#95060)
c282f50 
Pushes the chunking of `GET _nodes/stats` down to avoid creating
unboundedly large chunks. With this commit we yield one chunk per shard
(if `?level=shards`) or index (if `?level=indices`) and per HTTP client
and per transport action.

Closes #93985
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>bug :Data Management/Stats Statistics tracking and retrieval APIs Team:Data Management Meta label for data/management team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deeper chunking of node stats response DaveCTurner/elasticsearch
2 participants
@DaveCTurner @elasticsearchmachine