Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requiring the presence of the geoip fixture to run GeoIpDownloaderStats.testStats() #91662

Merged
merged 2 commits into from
Nov 18, 2022
Merged

Requiring the presence of the geoip fixture to run GeoIpDownloaderStats.testStats() #91662

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2029112
requiring the presence of the geoip fixture to run testStats
masseyke Nov 17, 2022
9c1d97c
changing the assumeTrue message
masseyke Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...p/src/internalClusterTest/java/org/elasticsearch/ingest/geoip/GeoIpDownloaderStatsIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,11 @@ public void disableDownloader() {
}

public void testStats() throws Exception {
/*
* Testing without the geoip endpoint fixture falls back to https://storage.googleapis.com/, which can cause this test to run too
* slowly to pass.
*/
assumeTrue("only test with fixture to have stable results", ENDPOINT != null);
GeoIpDownloaderStatsAction.Request req = new GeoIpDownloaderStatsAction.Request();
GeoIpDownloaderStatsAction.Response response = client().execute(GeoIpDownloaderStatsAction.INSTANCE, req).actionGet();
XContentTestUtils.JsonMapView jsonMapView = new XContentTestUtils.JsonMapView(convertToMap(response));
Expand Down