Requiring the presence of the geoip fixture to run GeoIpDownloaderStats.testStats() #91662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masseyke
added
>test
elasticsearchmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
@elasticmachine run elasticsearch-ci/bwc |
joegallo
approved these changes
Nov 18, 2022
gmarouli
pushed a commit
to gmarouli/elasticsearch
that referenced
this pull request
Feb 2, 2023
…ts.testStats() (elastic#91662) (cherry picked from commit ab17a13)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
gmarouli
added a commit
that referenced
this pull request
Feb 2, 2023
…ts.testStats() (#91662) (#93459) (cherry picked from commit ab17a13) authored-by: Keith Massey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the geoip endpoint fixture is not available, then we fall back to using https://storage.googleapis.com/ in GeoIpDownloaderStats. Downloading full-sized databases from there (vs. small versions of the databases from the fixture on localhost) can often take longer than 10 seconds, causing the test to fail.
Closes #87035