Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare synthetic source docs for tech-preview (#89358) #89392

Merged

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Aug 16, 2022

Now that we're releasing synthetic _source as a tech preview feature, we
no longer want to remove the docs from the non-release builds. And we
want to mark all of the headings describing synthetic _source as a
preview.

@nik9000 nik9000 added backport auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) v8.4.0 labels Aug 16, 2022
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🏎️

@elasticsearchmachine elasticsearchmachine merged commit b172db5 into elastic:8.4 Aug 16, 2022
Now that we're releasing synthetic _source as a tech preview feature, we
no longer want to remove the docs from the non-release builds. And we
want to mark all of the headings describing synthetic `_source` as a
preview.
@nik9000 nik9000 deleted the synthetic_source_docs_preview_8_4 branch August 16, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants