Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare synthetic source docs for tech-preview #89358

Merged
merged 1 commit into from
Aug 16, 2022
Merged

Prepare synthetic source docs for tech-preview #89358

merged 1 commit into from
Aug 16, 2022

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Aug 15, 2022

Now that we're releasing synthetic _source as a tech preview feature, we
no longer want to remove the docs from the non-release builds. And we
want to mark all of the headings describing synthetic _source as a
preview.

@nik9000 nik9000 added >docs General docs changes :Search Foundations/Mapping Index mappings, including merging and defining field types :StorageEngine/TSDB You know, for Metrics v8.4.0 v8.5.0 labels Aug 15, 2022
@nik9000 nik9000 requested review from romseygeek and kilfoyle August 15, 2022 22:05
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team Team:Search Meta label for search team Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Aug 15, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@nik9000
Prepare synthetic source docs for tech-preview
0645a2f 
Now that we're releasing synthetic _source as a tech preview feature, we
no longer want to remove the docs from the non-release builds. And we
want to mark all of the headings describing synthetic `_source` as a
preview.
romseygeek
romseygeek approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kilfoyle
kilfoyle approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚗

@nik9000 nik9000 merged commit 914e216 into elastic:main Aug 16, 2022
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 8.4 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 89358

@nik9000
Copy link
Member Author

nik9000 commented Aug 16, 2022

Backporting with #89392

elasticsearchmachine pushed a commit that referenced this pull request Aug 16, 2022
@nik9000
Prepare synthetic source docs for tech-preview (#89358) (#89392)
b172db5 
Now that we're releasing synthetic _source as a tech preview feature, we
no longer want to remove the docs from the non-release builds. And we
want to mark all of the headings describing synthetic `_source` as a
preview.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilfoyle kilfoyle kilfoyle approved these changes

@romseygeek romseygeek romseygeek approved these changes

Assignees
No one assigned
Labels
>docs General docs changes :Search Foundations/Mapping Index mappings, including merging and defining field types :StorageEngine/TSDB You know, for Metrics Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Docs Meta label for docs team Team:Search Meta label for search team v8.4.0 v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nik9000 @elasticsearchmachine @romseygeek @kilfoyle