Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.4] Script: Rename TIMESTAMP constant NOW in Metadata (#88870) #88877

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

stu-elastic
Copy link
Contributor

Backports the following commits to 8.4:

The value is `_now` and there was a previous metadata
value `_timestamp` (see test removal in elastic#88733) so the
name is confusing.

Also renames the method `getTimestamp()` to `getNow()`
to reflect the change.
@stu-elastic stu-elastic added :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >refactoring auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Core/Infra Meta label for core/infra team labels Jul 27, 2022
@elasticsearchmachine elasticsearchmachine merged commit 0bb0717 into elastic:8.4 Jul 27, 2022
@stu-elastic stu-elastic deleted the backport/8.4/pr-88870 branch July 27, 2022 23:11
@mark-vieira mark-vieira added v8.4.0 and removed v8.4.1 labels Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >refactoring Team:Core/Infra Meta label for core/infra team v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants