Script: Rename TIMESTAMP constant NOW in Metadata #88870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value is `_now` and there was a previous metadata value `_timestamp` (see test removal in elastic#88733) so the name is confusing. Also renames the method `getTimestamp()` to `getNow()` to reflect the change.
rjernst
reviewed
Jul 27, 2022
| @@ -35,7 +35,7 @@ class org.elasticsearch.script.Metadata { | |||
| String getVersionType() | |||
| void setVersionType(String) | |||
|
|
|||
| ZonedDateTime getTimestamp() | |||
There was a problem hiding this comment.
We need to provide backcompat for existing scripts. It could be done through an augmentation so it is isolated to just scripts.
There was a problem hiding this comment.
Is that the case for Metadata? It's in 8.4 but not documented or supported.
There was a problem hiding this comment.
Well, 8.4 has just been branched. So I guess this could change, but it will need to go back to that branch (it should be fine, since it was literally just branched today).
stu-elastic
added
:Core/Infra/Scripting
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
stu-elastic
added a commit
to stu-elastic/elasticsearch
that referenced
this pull request
Jul 27, 2022
The value is `_now` and there was a previous metadata value `_timestamp` (see test removal in elastic#88733) so the name is confusing. Also renames the method `getTimestamp()` to `getNow()` to reflect the change.
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value is
_nowand there was a previous metadatavalue
_timestamp(see test removal in #88733) so thename is confusing.
Also renames the method
getTimestamp()togetNow()to reflect the change.