Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log more details in TaskAssertions #88864

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Log more details in TaskAssertions #88864

merged 1 commit into from
Jul 28, 2022

Conversation

pxsalehi
Copy link
Member

Relates #88201

@pxsalehi pxsalehi added >test Issues or PRs that are addressing/adding tests :Distributed Coordination/Task Management Issues for anything around the Tasks API - both persistent and node level. labels Jul 27, 2022
@pxsalehi pxsalehi requested review from fcofdez and DaveCTurner July 27, 2022 15:54
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@elasticsearchmachine elasticsearchmachine added Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v8.5.0 labels Jul 27, 2022
fcofdez
fcofdez approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@fcofdez fcofdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pxsalehi
Copy link
Member Author

Thanks Francisco!

@pxsalehi pxsalehi merged commit 32d6d4a into elastic:main Jul 28, 2022
@pxsalehi pxsalehi mentioned this pull request Jul 28, 2022
Merged
pxsalehi added a commit to pxsalehi/elasticsearch that referenced this pull request Jul 28, 2022
@pxsalehi
Log more details in TaskAssertions (elastic#88864)
aeb0a7e
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 7.17

elasticsearchmachine pushed a commit that referenced this pull request Jul 28, 2022
@pxsalehi
Log more details in TaskAssertions (#88864) (#88881)
b08b301
weizijun added a commit to weizijun/elasticsearch that referenced this pull request Jul 29, 2022
@weizijun
Merge branch 'upstream/main' into number-support-single-type
964ab92 
* upstream/main:
  Add 8.5 migration docs (elastic#88923)
  Script: Reindex & UpdateByQuery Metadata (elastic#88665)
  Remove unused plugins dir var from server CLI (elastic#88917)
  Use tracing API in TaskManager (elastic#88885)
  Add source fallback for keyword fields using operation (elastic#88735)
  Prune changelogs after 8.3.3 release
  Bump versions after 8.3.3 release
  Add a test for checking for misspelled "dry_run" parameters for Desired Nodes API (elastic#88898)
  Speedup BalanceUnbalancedClusterTests (elastic#88794)
  Preventing exceptions on node shutdown in integration tests (elastic#88827)
  Do not trigger check part3 for test mute and docs PRs (elastic#88895)
  Add troubleshooting docs about data corruption (elastic#88760)
  Mute RollupActionSingleNodeTests#testRollupDatastream (elastic#88891)
  [DOCS] Domain splitting impacts API keys (elastic#88677)
  Fix SqlSearchIT testAllTypesWithRequestToOldNodes (elastic#88866) (elastic#88883)
  Update synthetic-source.asciidoc (elastic#88880)
  Log more details in TaskAssertions (elastic#88864)
  Make Tuple a record (elastic#88280)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcofdez fcofdez fcofdez approved these changes

@DaveCTurner DaveCTurner Awaiting requested review from DaveCTurner

Assignees
No one assigned
Labels
:Distributed Coordination/Task Management Issues for anything around the Tasks API - both persistent and node level. Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test Issues or PRs that are addressing/adding tests v7.17.6 v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pxsalehi @elasticsearchmachine @fcofdez