Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Tuple a record #88280

Merged
merged 5 commits into from
Jul 28, 2022
Merged

Make Tuple a record #88280

merged 5 commits into from
Jul 28, 2022

Conversation

arteam
Copy link
Contributor

@arteam arteam commented Jul 5, 2022

Tuple is used extensively across the ES codebase and can be effectively represent as a Java record.

@arteam arteam force-pushed the tuple-as-record branch from 727fe1b to 2e9e2b8 Compare July 5, 2022 16:06
@arteam arteam added >refactoring >non-issue :Core/Infra/Core Core issues without another label labels Jul 7, 2022
@arteam arteam marked this pull request as ready for review July 11, 2022 08:38
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Jul 11, 2022
@elasticsearchmachine elasticsearchmachine changed the base branch from master to main July 22, 2022 23:05
@arteam arteam requested a review from rjernst July 27, 2022 13:54
@mark-vieira mark-vieira added v8.5.0 and removed v8.4.0 labels Jul 27, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@arteam
Copy link
Contributor Author

arteam commented Jul 27, 2022

@elasticmachine update branch

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arteam
Copy link
Contributor Author

arteam commented Jul 27, 2022

@elasticmachine update branch

@arteam arteam merged commit 8a159e9 into elastic:main Jul 28, 2022
@arteam arteam deleted the tuple-as-record branch July 28, 2022 07:14
@arteam
Copy link
Contributor Author

arteam commented Jul 28, 2022

Thanks Nikola!

weizijun added a commit to weizijun/elasticsearch that referenced this pull request Jul 29, 2022
* upstream/main:
  Add 8.5 migration docs (elastic#88923)
  Script: Reindex & UpdateByQuery Metadata (elastic#88665)
  Remove unused plugins dir var from server CLI (elastic#88917)
  Use tracing API in TaskManager (elastic#88885)
  Add source fallback for keyword fields using operation (elastic#88735)
  Prune changelogs after 8.3.3 release
  Bump versions after 8.3.3 release
  Add a test for checking for misspelled "dry_run" parameters for Desired Nodes API (elastic#88898)
  Speedup BalanceUnbalancedClusterTests (elastic#88794)
  Preventing exceptions on node shutdown in integration tests (elastic#88827)
  Do not trigger check part3 for test mute and docs PRs (elastic#88895)
  Add troubleshooting docs about data corruption (elastic#88760)
  Mute RollupActionSingleNodeTests#testRollupDatastream (elastic#88891)
  [DOCS] Domain splitting impacts API keys (elastic#88677)
  Fix SqlSearchIT testAllTypesWithRequestToOldNodes (elastic#88866) (elastic#88883)
  Update synthetic-source.asciidoc (elastic#88880)
  Log more details in TaskAssertions (elastic#88864)
  Make Tuple a record (elastic#88280)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Core Core issues without another label >non-issue >refactoring Team:Core/Infra Meta label for core/infra team v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants