Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Split common cluster issues page into separate pages #88495

Merged
merged 1 commit into from
Jul 18, 2022
Merged

[DOCS] Split common cluster issues page into separate pages #88495

merged 1 commit into from
Jul 18, 2022

Conversation

abdonpijpelink
Copy link
Contributor

Closes #85610

@abdonpijpelink abdonpijpelink added >docs General docs changes Team:Docs Meta label for docs team auto-backport-and-merge v8.4.0 v8.3.3 labels Jul 13, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@debadair
Copy link
Contributor

@elasticmachine run elasticsearch-ci/docs rebuild

@debadair
Copy link
Contributor

The build is failing because of a link from the Kibana docs that linked to one of the headings on the common cluster issues page. It should be updated to link to the new standalone page. To get clean builds before merging, you'll have to update the Kibana page twice. Change it to link to the top of the common clusters page, merge this PR, and then update the Kibana page to link to the new page.

debadair
debadair approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@debadair debadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a "chicken-and-egg" issue with the cross-doc link from Kibana that's causing the build to fail, but otherwise these changes look good.

@abdonpijpelink abdonpijpelink changed the title Split common cluster issues page into separate pages [DOCS] Split common cluster issues page into separate pages Jul 14, 2022
@abdonpijpelink abdonpijpelink mentioned this pull request Jul 14, 2022
Merged
@abdonpijpelink
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/docs rebuild

@abdonpijpelink abdonpijpelink merged commit 26cc873 into elastic:master Jul 18, 2022
@abdonpijpelink abdonpijpelink deleted the 85610-split-common-cluster-issues-page branch July 18, 2022 15:54
lockewritesdocs pushed a commit to lockewritesdocs/elasticsearch that referenced this pull request Jul 19, 2022
@abdonpijpelink
Split common cluster issues page into separate pages (elastic#88495)
3cfd291 
(cherry picked from commit 26cc873)
@lockewritesdocs lockewritesdocs mentioned this pull request Jul 19, 2022
Merged
@lockewritesdocs
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.3

Questions ?

Please refer to the Backport tool documentation

elasticsearchmachine pushed a commit that referenced this pull request Jul 21, 2022
@abdonpijpelink
Split common cluster issues page into separate pages (#88495) (#88612)
cc5235a 
(cherry picked from commit 26cc873)

Co-authored-by: Abdon Pijpelink <[email protected]>
@abdonpijpelink abdonpijpelink mentioned this pull request Jan 25, 2023
Closed
@shainaraskas shainaraskas mentioned this pull request Apr 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@debadair debadair debadair approved these changes

@alaudazzi alaudazzi Awaiting requested review from alaudazzi

Assignees
No one assigned
Labels
>docs General docs changes Team:Docs Meta label for docs team v8.3.3 v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOCS] Split the page Fix common cluster issues into separate pages
4 participants
@abdonpijpelink @elasticmachine @debadair @lockewritesdocs