Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] make ML stats APIs cancellable #88030

Merged
merged 3 commits into from
Jun 28, 2022
Merged

[ML] make ML stats APIs cancellable #88030

merged 3 commits into from
Jun 28, 2022

Conversation

benwtrent
Copy link
Member

@benwtrent benwtrent commented Jun 24, 2022 •
edited by droberts195
Loading

Many machine learning stats APIs make multiple searches per call. Making them cancellable allows for those searches to be cancelled if the HTTP connection is closed.

This improves scalability and performance.

Relates #88010

@elasticmachine elasticmachine added the Team:ML Meta label for the ML team label Jun 24, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

przemekwitek
przemekwitek approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@przemekwitek przemekwitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

...c/main/java/org/elasticsearch/xpack/ml/action/TransportGetDataFrameAnalyticsStatsAction.java Outdated Show resolved Hide resolved
@benwtrent benwtrent requested a review from droberts195 June 28, 2022 16:11
droberts195
droberts195 approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benwtrent benwtrent merged commit 6b0beb7 into elastic:master Jun 28, 2022
@benwtrent benwtrent deleted the feature/ml-make-stats-cancellable branch June 28, 2022 17:23
@benwtrent benwtrent mentioned this pull request Jun 28, 2022
Open
30 tasks
@benwtrent benwtrent mentioned this pull request Jul 6, 2022
Closed
@benwtrent benwtrent mentioned this pull request Jul 19, 2022
Merged
elasticsearchmachine pushed a commit that referenced this pull request Jul 19, 2022
@benwtrent
[ML] fix ml API cancellation when http connection is closed (#88616)
0d7e4c2 
API cancellation was erroneously using the node-name for the parent task
id. Task ids are constructed via the node ID, not name. 

This fixes that bug.

related to:   - #88030  -
#88142  -
#88009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@przemekwitek przemekwitek przemekwitek approved these changes

@droberts195 droberts195 droberts195 approved these changes

Assignees
No one assigned
Labels
:ml Machine learning >non-issue Team:ML Meta label for the ML team v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benwtrent @elasticmachine @droberts195 @przemekwitek