-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] make trained model rest APIs cancellable #88009
Merged
benwtrent
merged 2 commits into
elastic:master
from
benwtrent:feature/ml-trained-model-stats-cancellable
Jun 24, 2022
Merged
[ML] make trained model rest APIs cancellable #88009
benwtrent
merged 2 commits into
elastic:master
from
benwtrent:feature/ml-trained-model-stats-cancellable
Jun 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/ml-core (Team:ML) |
30 tasks
dimitris-athanasiou
approved these changes
Jun 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -1174,30 +1208,6 @@ private Set<String> matchedResourceIds(String[] tokens) { | |||
return Collections.unmodifiableSet(matchedModels); | |||
} | |||
|
|||
private static <T> T handleSearchItem( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 19, 2022
benwtrent
added a commit
that referenced
this pull request
Jul 20, 2022
When an infer request is made, it may or may not be queued for later execution. If the caller making the inference request stops listening for the result, we should not execute action. This commit allows for infer requests made to deployed models to be cancelled even after they are queued for inference. Related to: #88009
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes all the trained model APIs cancellable, and addresses the handful of APIs that rely on our abstract resource structure.
closes: #87931
relates: #88010