[ML] rename trained model allocations to assignments #85503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion-assignment-rename
…tion-assignment-rename
benwtrent
commented
Apr 12, 2022
| public class DeleteTrainedModelAllocationAction extends ActionType<AcknowledgedResponse> { | ||
| public static final DeleteTrainedModelAllocationAction INSTANCE = new DeleteTrainedModelAllocationAction(); | ||
| public class DeleteTrainedModelAssignmentAction extends ActionType<AcknowledgedResponse> { | ||
| public static final DeleteTrainedModelAssignmentAction INSTANCE = new DeleteTrainedModelAssignmentAction(); | ||
| public static final String NAME = "cluster:internal/xpack/ml/model_allocation/delete"; |
There was a problem hiding this comment.
Renaming the actions broke WAY too much stuff. So, I didn't rename these internal actions.
|
Pinging @elastic/ml-core (Team:ML) |
…tion-assignment-rename
|
run elasticsearch-ci/full-bwc |
|
run elasticsearch-ci/full-bwc |
2 similar comments
|
run elasticsearch-ci/full-bwc |
|
run elasticsearch-ci/full-bwc |
|
@elasticmachine update branch |
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Apr 21, 2022
* master: (104 commits) fix: ordering terms aggregation on top metrics null values (elastic#85774) Fix up whitespace error introduced in elastic#85948 More docs re. removing cluster.initial_master_nodes (elastic#85948) [Test] Remove API key methods from HLRC (elastic#85802) Remove references to bootstrap.system_call_filter (elastic#85964) Move docker cgroup override to SystemJvmOptions (elastic#85960) Add connection accounting tests (elastic#85966) Remove MacOS from platform support testing matrix Remove custom KnnVectorFieldExistsQuery (elastic#85945) Relax data path deprecations from critical to warn (elastic#85952) Remove hppc from some "common" classes (elastic#85957) Move docker env var settings handling out of bash (elastic#85913) Remove hppc from task manager (elastic#85889) [ML] rename trained model allocations to assignments (elastic#85503) Remove hppc from multi*shard request and responses (elastic#85888) Consolidating logging initialization in cli launcher (elastic#85920) Convert license tools to use unified cli entrypoint (elastic#85919) Add noop detection to node shutdown actions (elastic#85914) Adjust SQL expended test output TSDB: Add timestamp provider to AggregationExecutionContext (elastic#85850) ... # Conflicts: # server/src/main/java/org/elasticsearch/search/aggregations/AggregationExecutionContext.java
dimitris-athanasiou
added a commit
to dimitris-athanasiou/elasticsearch
that referenced
this pull request
Jun 17, 2022
In elastic#85503 we renamed trained model allocations to assignments. However, it is important to wait for the full cluster to be upgraded before we rewrite the cluster state so that there are no undesired side-effects in a mixed cluster.
dimitris-athanasiou
added a commit
that referenced
this pull request
Jun 17, 2022
In #85503 we renamed trained model allocations to assignments. However, it is important to wait for the full cluster to be upgraded before we rewrite the cluster state so that there are no undesired side-effects in a mixed cluster.
dimitris-athanasiou
added a commit
to dimitris-athanasiou/elasticsearch
that referenced
this pull request
Jun 17, 2022
…c#87806) In elastic#85503 we renamed trained model allocations to assignments. However, it is important to wait for the full cluster to be upgraded before we rewrite the cluster state so that there are no undesired side-effects in a mixed cluster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames the internal concept of a trained model allocation into an assignment.
Now models are assigned to a node and routes created for inference. Not "allocated".
This is an internal rename only. The user facing concepts of trained models and deployments are untouched.