-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds cache_size, fixes for TrainedModelDeployment models #1817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethmlarson
force-pushed
the
start-ml-model-deployment
branch
from
August 4, 2022 14:42
3ea821c
to
eb2c578
Compare
benwtrent
reviewed
Aug 4, 2022
specification/ml/start_trained_model_deployment/MlStartTrainedModelDeploymentRequest.ts
Outdated
Show resolved
Hide resolved
sethmlarson
force-pushed
the
start-ml-model-deployment
branch
from
August 8, 2022 12:18
eb2c578
to
c4e9a96
Compare
Thanks for the review comments @benwtrent! Could you give this another quick check that nothing got missed? |
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
benwtrent
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While adding the
cache_size
parameter toml.start_trained_model_deployment
API for 8.4 I noticed a renaming of "allocation" to "assignment" had happened during 8.3 that we missed unfortunately. Made all the fixes for that renaming in this PR as well.