Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds cache_size, fixes for TrainedModelDeployment models #1817

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

sethmlarson
Copy link
Contributor

While adding the cache_size parameter to ml.start_trained_model_deployment API for 8.4 I noticed a renaming of "allocation" to "assignment" had happened during 8.3 that we missed unfortunately. Made all the fixes for that renaming in this PR as well.

@sethmlarson sethmlarson requested review from benwtrent and a team August 4, 2022 14:40
@sethmlarson sethmlarson force-pushed the start-ml-model-deployment branch from 3ea821c to eb2c578 Compare August 4, 2022 14:42
@elastic elastic deleted a comment from github-actions bot Aug 4, 2022
specification/ml/_types/TrainedModel.ts Outdated Show resolved Hide resolved
specification/ml/_types/TrainedModel.ts Outdated Show resolved Hide resolved
specification/ml/_types/TrainedModel.ts Outdated Show resolved Hide resolved
specification/ml/_types/TrainedModel.ts Outdated Show resolved Hide resolved
specification/ml/_types/TrainedModel.ts Show resolved Hide resolved
@sethmlarson sethmlarson force-pushed the start-ml-model-deployment branch from eb2c578 to c4e9a96 Compare August 8, 2022 12:18
@sethmlarson sethmlarson requested a review from benwtrent August 8, 2022 12:19
@sethmlarson
Copy link
Contributor Author

Thanks for the review comments @benwtrent! Could you give this another quick check that nothing got missed?

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2022

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ml.close_job 🟢 62/62 61/61
ml.delete_calendar_event 🟢 4/4 4/4
ml.delete_calendar_job 🟢 3/3 3/3
ml.delete_calendar 🟢 5/5 5/5
ml.delete_data_frame_analytics 🟢 2/2 2/2
ml.delete_datafeed 🟢 3/3 3/3
ml.delete_expired_data 🟢 5/5 5/5
ml.delete_filter 🟢 27/27 27/27
ml.delete_forecast 🟢 3/3 3/3
ml.delete_job 🟢 47/47 47/47
ml.delete_model_snapshot 🟢 2/2 2/2
ml.delete_trained_model_alias 🟢 3/3 3/3
ml.delete_trained_model 🟢 3/3 3/3
ml.estimate_model_memory 🟢 16/16 16/16
ml.evaluate_data_frame 🟢 22/22 22/22
ml.explain_data_frame_analytics 🟢 7/7 7/7
ml.flush_job 🟢 15/15 15/15
ml.forecast 🟢 1/1 1/1
ml.get_buckets 🟢 14/14 14/14
ml.get_calendar_events 🟢 17/17 17/17
ml.get_calendars 🟢 17/17 17/17
ml.get_categories 🟢 12/12 12/12
ml.get_data_frame_analytics_stats 🟢 12/12 12/12
ml.get_data_frame_analytics 🟢 17/17 17/17
ml.get_datafeed_stats 🟢 27/27 27/27
ml.get_datafeeds 🟢 20/20 20/20
ml.get_filters 🟢 13/13 13/13
ml.get_influencers 🟢 11/11 11/11
ml.get_job_stats 🟢 31/31 31/31
ml.get_jobs 🟢 31/31 31/31
ml.get_memory_stats 🟢 6/6 6/6
ml.get_model_snapshot_upgrade_stats 🟢 3/3 3/3
ml.get_model_snapshots 🟢 18/18 18/18
ml.get_overall_buckets 🟢 16/16 15/15
ml.get_records 🟢 8/8 8/8
ml.get_trained_models_stats 🔴 13/13 12/13
ml.get_trained_models 🔴 21/27 25/27
ml.infer_trained_model 🔴 3/3 2/3
ml.info 🟢 10/10 10/10
ml.open_job 🔴 83/83 9/83
ml.post_calendar_events 🟢 21/21 21/21
ml.post_data 🔴 8/10 13/17
ml.preview_data_frame_analytics 🟢 3/3 3/3
ml.preview_datafeed 🔴 10/17 8/17
ml.put_calendar_job 🔴 11/12 12/12
ml.put_calendar 🟢 135/135 135/135
ml.put_data_frame_analytics 🟢 33/33 33/33
ml.put_datafeed 🔴 70/71 12/71
ml.put_filter 🟢 27/27 27/27
ml.put_job 🔴 189/226 224/224
ml.put_trained_model_alias 🟢 9/9 9/9
ml.put_trained_model_definition_part Missing test Missing test
ml.put_trained_model_vocabulary Missing test Missing test
ml.put_trained_model 🔴 3/5 3/5
ml.reset_job 🟢 2/2 2/2
ml.revert_model_snapshot 🟢 2/2 2/2
ml.set_upgrade_mode 🟢 6/6 6/6
ml.start_data_frame_analytics 🟢 1/1 1/1
ml.start_datafeed 🟢 24/24 24/24
ml.start_trained_model_deployment 🟢 2/2 2/2
ml.stop_data_frame_analytics 🟢 5/5 5/5
ml.stop_datafeed 🟢 17/17 17/17
ml.stop_trained_model_deployment 🟢 2/2 2/2
ml.update_data_frame_analytics 🟢 2/2 2/2
ml.update_datafeed 🔴 6/7 1/7
ml.update_filter 🟢 3/3 3/3
ml.update_job 🔴 3/5 5/5
ml.update_model_snapshot 🟢 3/3 3/3
ml.upgrade_job_snapshot 🟢 3/3 3/3
ml.validate_detector 🟢 2/2 2/2
ml.validate 🟢 3/3 3/3

You can validate these APIs yourself by using the make validate target.

@sethmlarson sethmlarson merged commit 6c20268 into main Aug 8, 2022
@sethmlarson sethmlarson deleted the start-ml-model-deployment branch August 8, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants