Rollback switch expressions in the SQL plugin #82349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was updated to Java 8 compatibility in elastic#82274
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
arteam
changed the title
idegtiarenko
approved these changes
Jan 10, 2022
bpintea
reviewed
Jan 10, 2022
| case HALF_FLOAT: | ||
| case SCALED_FLOAT: | ||
| case DOUBLE: | ||
| return Boolean.valueOf(Integer.signum(((Number) val).intValue()) != 0); |
There was a problem hiding this comment.
This should be reverted to it's original Boolean.valueOf(((Number) val).doubleValue() != 0), as it yields incorrect results for non-zero floats in (-1, 1)
There was a problem hiding this comment.
Hm, it had been set to return Boolean.valueOf(Integer.signum(((Number) val).intValue()) != 0), before I started working on switch expression refactoring. Maybe it was changed at some point before the switch expression change?
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Jan 10, 2022
It was updated to Java 8 compatibility in elastic#82274 (cherry picked from commit 78509f4)
arteam
added a commit
that referenced
this pull request
Jan 10, 2022
JEP 361[https://openjdk.java.net/jeps/361] added support for switch expressions which can be much more terse and less error-prone than switch statements. Another useful feature of switch expressions is exhaustiveness: we can make sure that an enum switch expression covers all the cases at compile time. (cherry picked from commit 0699c93) * Rollback switch expressions for the SQL plugin (#82349) It was updated to Java 8 compatibility in #82274 (cherry picked from commit 78509f4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin's source compatibility was updated to Java 8 in #82274, so switch expressions are not supported anymore.
See #82178