-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Java 8 for JDBC driver target compatibility version #82274
Conversation
Pinging @elastic/es-ql (Team:QL) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Should there be any checks to prevent usage of non JDK 1.8 APIs?
This is accomplished by way of passing the |
💚 Backport successful
|
It was updated to Java 8 compatibility in elastic#82274
It was updated to Java 8 compatibility in #82274
It was updated to Java 8 compatibility in elastic#82274 (cherry picked from commit 78509f4)
JEP 361[https://openjdk.java.net/jeps/361] added support for switch expressions which can be much more terse and less error-prone than switch statements. Another useful feature of switch expressions is exhaustiveness: we can make sure that an enum switch expression covers all the cases at compile time. (cherry picked from commit 0699c93) * Rollback switch expressions for the SQL plugin (#82349) It was updated to Java 8 compatibility in #82274 (cherry picked from commit 78509f4)
Updates the JDBC driver to compile against Java 8 for compatibility reasons. Some updates were made to remove references to post-Java 8 APIs.