validate snapshot has global state before restoring #82037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible to restore from a snapshot with a global state even if it does not have one. This pr adds validation for this case.
idegtiarenko
added
>bug
:Distributed Coordination/Snapshot/Restore
|
Pinging @elastic/es-distributed (Team:Distributed) |
idegtiarenko
commented
Dec 23, 2021
| @@ -158,7 +158,7 @@ public void testIncludeGlobalState() throws Exception { | |||
| logger.info("--> try restoring cluster state from snapshot without global state"); | |||
There was a problem hiding this comment.
I should revisit the log entries as well
There was a problem hiding this comment.
Thanks Ievgen, this looks good. I would like to add documentation to the restore page explaining that you can only restore global state if the snapshot was taken with global state. Also, I wonder if we should not list it as breaking, only to highlight this to the few users who might be impacted.
server/src/main/java/org/elasticsearch/snapshots/RestoreService.java
Outdated
Show resolved
Hide resolved
idegtiarenko
commented
Jan 17, 2022
| @@ -170,6 +170,9 @@ ingest pipelines and {ilm-init} lifecycle policies that exist in your cluster | |||
| and replaces them with the corresponding items from the snapshot. | |||
|
|
|||
| Use the `feature_states` parameter to configure how feature states are restored. | |||
|
|
|||
| If `include_global_state` is `true` and a snapshot was created without a global | |||
| state then restore will fail. | |||
There was a problem hiding this comment.
@henningandersen please let me know if you have ideas as for other sections this note should be added to
henningandersen
approved these changes
Jan 17, 2022
docs/reference/snapshot-restore/apis/restore-snapshot-api.asciidoc
Outdated
Show resolved
Hide resolved
…idoc Co-authored-by: Henning Andersen <[email protected]>
💔 Backport failed
You can use sqren/backport to manually backport by running |
idegtiarenko
added a commit
to idegtiarenko/elasticsearch
that referenced
this pull request
Jan 17, 2022
It is possible to restore from a snapshot with a global state even if it does not have one. This pr adds validation to prevent this from happening. (cherry picked from commit e7d8991)
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is possible to restore with
include_global_state: truefrom a snapshot that does not have a global state.This behavior will nullify cluster state once #81373 is merged.
This pr adds explicit validation and error message to prevent damaging cluster state.
closes #82019