Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail with error when restoring global state from a snapshot that does not have one #82019

Closed
idegtiarenko opened this issue Dec 22, 2021 · 1 comment · Fixed by #82037
Closed

Fail with error when restoring global state from a snapshot that does not have one #82019

idegtiarenko opened this issue Dec 22, 2021 · 1 comment · Fixed by #82037
Assignees
@idegtiarenko
Labels
>bug :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.

Comments

@idegtiarenko
Copy link
Contributor

idegtiarenko commented Dec 22, 2021 •
edited
Loading

Currently elasticsearch allow to restore a global state from a snapshot that does not have one.
This silently succeed without changing anything. Once #81247 is fixed this could result in nullifying entire cluster state.

Elasticsearch version (bin/elasticsearch --version): 8.x and likely earlier

Description of the problem including expected versus actual behavior:

Steps to reproduce:

  • create a cluster with a snapshot repository
  • create a snapshot with "include_global_state": false
  • restore the snapshot with "include_global_state": true

Elasticsearch should return an error in such case, but currently silently succeed without changing the global state.
@idegtiarenko idegtiarenko self-assigned this Dec 22, 2021
@idegtiarenko idegtiarenko mentioned this issue Dec 22, 2021
Merged
@idegtiarenko idegtiarenko added the :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs label Dec 22, 2021
@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Dec 22, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

This was referenced Dec 22, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@idegtiarenko idegtiarenko

Labels
>bug :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

validate snapshot has global state before restoring idegtiarenko/elasticsearch
2 participants
@idegtiarenko @elasticmachine