Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the unfollow action in the frozen phase #81434

Merged
merged 3 commits into from
Dec 7, 2021

Conversation

andreidan
Copy link
Contributor

The unfollow actions is injected before some of the actions that yield
the managed index unsafe to use in a CCR environment (eg. rollover,
searchable_snapshot, shrink).

This was not allowed in the frozen phase, however we do have the
searchable_snapshot action available.

This commit makes the unfollow action available in the frozen phase.

The `unfollow` actions is injected before some of the actions that yield
the managed index unsafe to use in a CCR environment (eg. rollover,
searchable_snapshot, shrink).

This was not allowed in the `frozen` phase, however we do have the
`searchable_snapshot` action available.

This commit makes the `unfollow` action available in the frozen phase.
@andreidan andreidan requested a review from dakrone December 7, 2021 14:00
@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Dec 7, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but we have a serious mismatch for it in the HLRC's LifecyclePolicy (which has its own set of allowed actions, it's entirely missing the frozen phase!)

I opened #81461 for fixing that.

@andreidan andreidan merged commit 8ba6f55 into elastic:master Dec 7, 2021
andreidan added a commit to andreidan/elasticsearch that referenced this pull request Dec 7, 2021
* Allow the `unfollow` action in the frozen phase

The `unfollow` actions is injected before some of the actions that yield
the managed index unsafe to use in a CCR environment (eg. rollover,
searchable_snapshot, shrink).

This was not allowed in the `frozen` phase, however we do have the
`searchable_snapshot` action available.

This commit makes the `unfollow` action available in the frozen phase.
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.0
7.16 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 81434

andreidan added a commit to andreidan/elasticsearch that referenced this pull request Dec 8, 2021
* Allow the `unfollow` action in the frozen phase

The `unfollow` actions is injected before some of the actions that yield
the managed index unsafe to use in a CCR environment (eg. rollover,
searchable_snapshot, shrink).

This was not allowed in the `frozen` phase, however we do have the
`searchable_snapshot` action available.

This commit makes the `unfollow` action available in the frozen phase.

(cherry picked from commit 8ba6f55)
Signed-off-by: Andrei Dan <[email protected]>

# Conflicts:
#	x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/ilm/TimeseriesLifecycleTypeTests.java
elasticsearchmachine pushed a commit that referenced this pull request Dec 8, 2021
* Allow the `unfollow` action in the frozen phase (#81434)

* Allow the `unfollow` action in the frozen phase

The `unfollow` actions is injected before some of the actions that yield
the managed index unsafe to use in a CCR environment (eg. rollover,
searchable_snapshot, shrink).

This was not allowed in the `frozen` phase, however we do have the
`searchable_snapshot` action available.

This commit makes the `unfollow` action available in the frozen phase.

* Fix testValidateFrozenPhase (#81479)

Always add the `searchable_snapshot` action in the frozen phase.

(cherry picked from commit cd344e3)
Signed-off-by: Andrei Dan <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Dec 8, 2021
* Allow the `unfollow` action in the frozen phase

The `unfollow` actions is injected before some of the actions that yield
the managed index unsafe to use in a CCR environment (eg. rollover,
searchable_snapshot, shrink).

This was not allowed in the `frozen` phase, however we do have the
`searchable_snapshot` action available.

This commit makes the `unfollow` action available in the frozen phase.

(cherry picked from commit 8ba6f55)
Signed-off-by: Andrei Dan <[email protected]>

# Conflicts:
#	x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/ilm/TimeseriesLifecycleTypeTests.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Data Management/ILM+SLM Index and Snapshot lifecycle management Team:Data Management Meta label for data/management team v7.16.1 v8.0.0-rc2 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants