Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HLRC's LifecyclePolicy is missing multiple valid actions in ALLOWED_ACTIONS #81461

Closed
dakrone opened this issue Dec 7, 2021 · 1 comment · Fixed by #81483
Closed

HLRC's LifecyclePolicy is missing multiple valid actions in ALLOWED_ACTIONS #81461

dakrone opened this issue Dec 7, 2021 · 1 comment · Fixed by #81483
Labels
>bug Team:Data Management Meta label for data/management team

Comments

@dakrone
Copy link
Member

dakrone commented Dec 7, 2021

The ALLOWED_ACTIONS map in the HLRC LifecyclePolicy.java is missing actions (actually the entire frozen phase). We should bring it up to parity in the 7.x timeseries.
@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Dec 7, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

dakrone added a commit to dakrone/elasticsearch that referenced this issue Dec 7, 2021
@dakrone
Change HLRC's LifecyclePolicy to allow all valid ILM actions
06d0e6b 
This commit changes the High Level Rest Client's `LifecyclePolicy` implementation to allow all the
same valid actions for each phase that ILM supports. It was previously missing actions in the hot
and cold phases, as well as missing the frozen phase entirely.

This also adds a test that uses the "real" `TimeseriesLifecycleType.ORDERED_*ACTIONS` lists so that
if an action is added or removed in the future the test will fail.

Resolves elastic#81461
@dakrone dakrone mentioned this issue Dec 7, 2021
Merged
elasticsearchmachine pushed a commit that referenced this issue Dec 15, 2021
@dakrone
Change HLRC's LifecyclePolicy to allow all valid ILM actions (#81483)
6247248 
This commit changes the High Level Rest Client's `LifecyclePolicy`
implementation to allow all the same valid actions for each phase that
ILM supports. It was previously missing actions in the hot and cold
phases, as well as missing the frozen phase entirely. This also adds a
test that uses the "real" `TimeseriesLifecycleType.ORDERED_*ACTIONS`
lists so that if an action is added or removed in the future the test
will fail. Resolves #81461
dakrone added a commit to dakrone/elasticsearch that referenced this issue Dec 15, 2021
@dakrone
Change HLRC's LifecyclePolicy to allow all valid ILM actions (elastic…
3c5064f 
…#81483)

This commit changes the High Level Rest Client's `LifecyclePolicy`
implementation to allow all the same valid actions for each phase that
ILM supports. It was previously missing actions in the hot and cold
phases, as well as missing the frozen phase entirely. This also adds a
test that uses the "real" `TimeseriesLifecycleType.ORDERED_*ACTIONS`
lists so that if an action is added or removed in the future the test
will fail. Resolves elastic#81461
elasticsearchmachine pushed a commit that referenced this issue Dec 15, 2021
@dakrone
Change HLRC's LifecyclePolicy to allow all valid ILM actions (#81483) (…
d262b11 
…#81746)

This commit changes the High Level Rest Client's `LifecyclePolicy`
implementation to allow all the same valid actions for each phase that
ILM supports. It was previously missing actions in the hot and cold
phases, as well as missing the frozen phase entirely. This also adds a
test that uses the "real" `TimeseriesLifecycleType.ORDERED_*ACTIONS`
lists so that if an action is added or removed in the future the test
will fail. Resolves #81461
dakrone added a commit to dakrone/elasticsearch that referenced this issue Dec 15, 2021
@dakrone
Change HLRC's LifecyclePolicy to allow all valid ILM actions (elastic…
ab14efe 
…#81483)

This commit changes the High Level Rest Client's `LifecyclePolicy`
implementation to allow all the same valid actions for each phase that
ILM supports. It was previously missing actions in the hot and cold
phases, as well as missing the frozen phase entirely. This also adds a
test that uses the "real" `TimeseriesLifecycleType.ORDERED_*ACTIONS`
lists so that if an action is added or removed in the future the test
will fail. Resolves elastic#81461
# Conflicts:
#	client/rest-high-level/src/test/java/org/elasticsearch/client/indexlifecycle/LifecyclePolicyTests.java
#	x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ilm/TimeseriesLifecycleType.java
elasticsearchmachine pushed a commit that referenced this issue Dec 15, 2021
@dakrone
[7.16] Change HLRC's LifecyclePolicy to allow all valid ILM actions (#…
cb5766c 
…81483) (#81765)

* Change HLRC's LifecyclePolicy to allow all valid ILM actions (#81483)

This commit changes the High Level Rest Client's `LifecyclePolicy`
implementation to allow all the same valid actions for each phase that
ILM supports. It was previously missing actions in the hot and cold
phases, as well as missing the frozen phase entirely. This also adds a
test that uses the "real" `TimeseriesLifecycleType.ORDERED_*ACTIONS`
lists so that if an action is added or removed in the future the test
will fail. Resolves #81461
# Conflicts:
#	client/rest-high-level/src/test/java/org/elasticsearch/client/indexlifecycle/LifecyclePolicyTests.java
#	x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ilm/TimeseriesLifecycleType.java

* Fix test
@dakrone dakrone mentioned this issue Dec 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>bug Team:Data Management Meta label for data/management team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change HLRC's LifecyclePolicy to allow all valid ILM actions dakrone/elasticsearch
2 participants
@dakrone @elasticmachine