SQL: stabilize SqlSearchPageTimeoutIT #79928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticmachine
added
the
Team:QL (Deprecated)
|
Pinging @elastic/es-ql (Team:QL) |
Luegg
added
auto-backport-and-merge
auto-merge-without-approval
|
@elasticmachine run elasticsearch-ci/part-2 |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 27, 2021
since #79928 is blocked by other failing tests I'm just muting it for now.
Luegg
pushed a commit
to Luegg/elasticsearch
that referenced
this pull request
Oct 27, 2021
since elastic#79928 is blocked by other failing tests I'm just muting it for now.
Luegg
pushed a commit
to Luegg/elasticsearch
that referenced
this pull request
Oct 27, 2021
since elastic#79928 is blocked by other failing tests I'm just muting it for now.
Luegg
pushed a commit
that referenced
this pull request
Oct 27, 2021
Luegg
pushed a commit
that referenced
this pull request
Oct 27, 2021
Luegg
removed
auto-merge-without-approval
Luegg
added
auto-backport-and-merge
auto-merge-without-approval
Luegg
pushed a commit
to Luegg/elasticsearch
that referenced
this pull request
Oct 28, 2021
elastic#79360 introduced a [flaky test](https://gradle-enterprise.elastic.co/scans/tests?search.relativeStartTime=P7D&search.timeZoneId=Europe/Zurich&tests.container=org.elasticsearch.xpack.sql.action.SqlSearchPageTimeoutIT&tests.sortField=FAILED&tests.test=testSearchContextIsCleanedUpAfterPageTimeoutForHitsQueries&tests.unstableOnly=true). Increasing the page timeout used in the initial query should ensure that line 44 should always see the search context (I suspect that it has been removed before `getNumberOfSearchContexts()` reads the search contexts). I've run the test with a 1000 iterations locally on both master and 7.16 and it didn't fail.
Luegg
pushed a commit
to Luegg/elasticsearch
that referenced
this pull request
Oct 28, 2021
elastic#79360 introduced a [flaky test](https://gradle-enterprise.elastic.co/scans/tests?search.relativeStartTime=P7D&search.timeZoneId=Europe/Zurich&tests.container=org.elasticsearch.xpack.sql.action.SqlSearchPageTimeoutIT&tests.sortField=FAILED&tests.test=testSearchContextIsCleanedUpAfterPageTimeoutForHitsQueries&tests.unstableOnly=true). Increasing the page timeout used in the initial query should ensure that line 44 should always see the search context (I suspect that it has been removed before `getNumberOfSearchContexts()` reads the search contexts). I've run the test with a 1000 iterations locally on both master and 7.16 and it didn't fail.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 28, 2021
#79360 introduced a [flaky test](https://gradle-enterprise.elastic.co/scans/tests?search.relativeStartTime=P7D&search.timeZoneId=Europe/Zurich&tests.container=org.elasticsearch.xpack.sql.action.SqlSearchPageTimeoutIT&tests.sortField=FAILED&tests.test=testSearchContextIsCleanedUpAfterPageTimeoutForHitsQueries&tests.unstableOnly=true). Increasing the page timeout used in the initial query should ensure that line 44 should always see the search context (I suspect that it has been removed before `getNumberOfSearchContexts()` reads the search contexts). I've run the test with a 1000 iterations locally on both master and 7.16 and it didn't fail.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 28, 2021
#79360 introduced a [flaky test](https://gradle-enterprise.elastic.co/scans/tests?search.relativeStartTime=P7D&search.timeZoneId=Europe/Zurich&tests.container=org.elasticsearch.xpack.sql.action.SqlSearchPageTimeoutIT&tests.sortField=FAILED&tests.test=testSearchContextIsCleanedUpAfterPageTimeoutForHitsQueries&tests.unstableOnly=true). Increasing the page timeout used in the initial query should ensure that line 44 should always see the search context (I suspect that it has been removed before `getNumberOfSearchContexts()` reads the search contexts). I've run the test with a 1000 iterations locally on both master and 7.16 and it didn't fail. Co-authored-by: Elastic Machine <[email protected]>
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Oct 28, 2021
…formance * upstream/master: (153 commits) [ML] update truncation default & adding field output when input is truncated (elastic#79942) [ML] stop using isAllowedByLicense for model license checks (elastic#79908) [ML] Retain built-in ML roles granting Kibana privileges (elastic#80014) [Transform] remove old mixed cluster BWC layers, not required for 8x (elastic#79927) Increase test timeout for CoordinatorTests testAllSearchesExecuted [Transform] add rolling upgrade tests for upgrade endpoint (elastic#79721) [ML] Update trained model docs for truncate parameter for bert tokenization (elastic#79652) `CoordinatorTests` sometimes needs three term bumps (elastic#79574) [ML] Account for service being triggered twice in tests (elastic#80000) SearchContext: remove unused variable (elastic#79917) Revert "Deprecate resolution loss on date field (elastic#78921)" (elastic#79914) Re-enable GeoIpDownloaderIT#testStartWithNoDatabases() (elastic#79907) Fix SnapshotBasedIndexRecoveryIT#testSeqNoBasedRecoveryIsUsedAfterPrimaryFailOver (elastic#79469) Fix RecoverySourceHandlerTests (elastic#79546) SQL: stabilize SqlSearchPageTimeoutIT (elastic#79928) Wait 3 seconds for the server to reload trust (elastic#79778) Skip automatically preserved request headers when rewriting (elastic#79973) Check whether stdout is a real console (elastic#79882) Convert remote license checker to use LicensedFeature (elastic#79876) Miscellaneous fixes for LDAP SDK v6 upgrade (elastic#79891) ... # Conflicts: # libs/x-content/src/main/java/org/elasticsearch/xcontent/support/filtering/FilterPath.java # libs/x-content/src/test/java/org/elasticsearch/xcontent/support/filtering/FilterPathGeneratorFilteringTests.java # libs/x-content/src/test/java/org/elasticsearch/xcontent/support/filtering/FilterPathTests.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#79360 introduced a flaky test.
Increasing the page timeout used in the initial query should ensure that line 44 should always see the search context (I suspect that it has been removed before
getNumberOfSearchContexts()reads the search contexts).I've run the test with a 1000 iterations locally on both master and 7.16 and it didn't fail.