Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Update trained model docs for truncate parameter for bert tokenization #79652

Conversation

benwtrent
Copy link
Member

No description provided.

@benwtrent benwtrent added >docs General docs changes :ml Machine learning v8.0.0 labels Oct 21, 2021
@elasticmachine elasticmachine added Team:Docs Meta label for docs team Team:ML Meta label for the ML team labels Oct 21, 2021
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some suggestions and one question

docs/reference/ml/ml-shared.asciidoc Outdated Show resolved Hide resolved
docs/reference/ml/ml-shared.asciidoc Outdated Show resolved Hide resolved
docs/reference/ml/ml-shared.asciidoc Outdated Show resolved Hide resolved
docs/reference/ml/ml-shared.asciidoc Outdated Show resolved Hide resolved
docs/reference/ml/ml-shared.asciidoc Outdated Show resolved Hide resolved
docs/reference/ml/ml-shared.asciidoc Outdated Show resolved Hide resolved
docs/reference/ml/ml-shared.asciidoc Outdated Show resolved Hide resolved
docs/reference/ml/ml-shared.asciidoc Outdated Show resolved Hide resolved
@benwtrent benwtrent requested a review from lcawl October 26, 2021 11:40
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs LGTM, thanks!

@benwtrent benwtrent merged commit d2b6383 into elastic:master Oct 28, 2021
@benwtrent benwtrent deleted the docs/ml-add-new-truncate-param-to-bert-tokenization branch October 28, 2021 11:19
benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Oct 28, 2021
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.0

weizijun added a commit to weizijun/elasticsearch that referenced this pull request Oct 28, 2021
…formance

* upstream/master: (153 commits)
  [ML] update truncation default & adding field output when input is truncated (elastic#79942)
  [ML] stop using isAllowedByLicense for model license checks (elastic#79908)
  [ML] Retain built-in ML roles granting Kibana privileges (elastic#80014)
  [Transform] remove old mixed cluster BWC layers, not required for 8x (elastic#79927)
  Increase test timeout for CoordinatorTests testAllSearchesExecuted
  [Transform] add rolling upgrade tests for upgrade endpoint (elastic#79721)
  [ML] Update trained model docs for truncate parameter for bert tokenization (elastic#79652)
  `CoordinatorTests` sometimes needs three term bumps (elastic#79574)
  [ML] Account for service being triggered twice in tests (elastic#80000)
  SearchContext: remove unused variable (elastic#79917)
  Revert "Deprecate resolution loss on date field (elastic#78921)" (elastic#79914)
  Re-enable GeoIpDownloaderIT#testStartWithNoDatabases() (elastic#79907)
  Fix SnapshotBasedIndexRecoveryIT#testSeqNoBasedRecoveryIsUsedAfterPrimaryFailOver (elastic#79469)
  Fix RecoverySourceHandlerTests (elastic#79546)
  SQL: stabilize SqlSearchPageTimeoutIT (elastic#79928)
  Wait 3 seconds for the server to reload trust (elastic#79778)
  Skip automatically preserved request headers when rewriting (elastic#79973)
  Check whether stdout is a real console (elastic#79882)
  Convert remote license checker to use LicensedFeature (elastic#79876)
  Miscellaneous fixes for LDAP SDK v6 upgrade (elastic#79891)
  ...

# Conflicts:
#	libs/x-content/src/main/java/org/elasticsearch/xcontent/support/filtering/FilterPath.java
#	libs/x-content/src/test/java/org/elasticsearch/xcontent/support/filtering/FilterPathGeneratorFilteringTests.java
#	libs/x-content/src/test/java/org/elasticsearch/xcontent/support/filtering/FilterPathTests.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :ml Machine learning Team:Docs Meta label for docs team Team:ML Meta label for the ML team v8.0.0-beta1 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants