Remove getValue and getValues from Field #79516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdconrad
added
:Core/Infra/Scripting
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
jdconrad
added
the
auto-backport
|
@rjernst Thanks for the review. |
jdconrad
added
v7.16.0
and removed
auto-backport
💔 Backport failed
You can use sqren/backport to manually backport by running |
jdconrad
added a commit
to jdconrad/elasticsearch
that referenced
this pull request
Oct 19, 2021
With duck-typing in Painless and potentially non-dynamic languages requiring a cast under the current design, this change removes unnecessary methods from the Field base class. The removal of getValue and getValues allows sub classes to return primitives from these methods and opens up potential design space for performance improvements. Note this removes getLong from the unsigned long field; however, this is currently undocumented and unused behavior.
jdconrad
added a commit
that referenced
this pull request
Oct 19, 2021
With duck-typing in Painless and potentially non-dynamic languages requiring a cast under the current design, this change removes unnecessary methods from the Field base class. The removal of getValue and getValues allows sub classes to return primitives from these methods and opens up potential design space for performance improvements. Note this removes getLong from the unsigned long field; however, this is currently undocumented and unused behavior.
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Oct 20, 2021
* upstream/master: (24 commits) Implement framework for migrating system indices (elastic#78951) Improve transient settings deprecation message (elastic#79504) Remove getValue and getValues from Field (elastic#79516) Store Template's mappings as bytes for disk serialization (elastic#78746) [ML] Add queue_capacity setting to start deployment API (elastic#79433) [ML] muting rest compat test issue elastic#79518 (elastic#79519) Avoid redundant available indices check (elastic#76540) Re-enable BWC tests TEST Ensure password 14 chars length on Kerberos FIPS tests (elastic#79496) [DOCS] Temporarily remove APM links (elastic#79411) Fix CCSDuelIT for skipped shards (elastic#79490) Add other time accounting in HotThreads (elastic#79392) Add deprecation info API entries for deprecated monitoring settings (elastic#78799) Add note in breaking changes for nameid_format (elastic#77785) Use 'migration' instead of 'upgrade' in GET system feature migration status responses (elastic#79302) Upgrade lucene version 8b68bf60c98 (elastic#79461) Use Strings#EMPTY_ARRAY (elastic#79452) Quicker shared cache file preallocation (elastic#79447) [ML] Removing some code that's obsolete for 8.0 (elastic#79444) Ensure indexing_data CCR requests are compressed (elastic#79413) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With duck-typing in Painless and potentially non-dynamic languages requiring a cast under the current design, this change removes unnecessary methods from the Field base class. The removal of getValue and getValues allows sub classes to return primitives from these methods and opens up potential design space for performance improvements.
Note this removes getLong from the unsigned long field; however, this is currently undocumented and unused behavior.