Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'migration' instead of 'upgrade' in GET system feature migration status responses #79302

Conversation

williamrandolph
Copy link
Contributor

In #78802, we updated our docs to consistently use the term "migration" instead of "upgrade" for the operations that keep system indices up-to-date with the latest release of Elasticsearch.

Here, we change the API response to be consistent with the documentation.

We will follow up with a refactoring PR to change the names of classes to use the same terminology, but at the moment there is a lot of turbulence on the release branches, so we want this PR to be as minimal as possible.

@williamrandolph williamrandolph added :Core/Infra/Core Core issues without another label v8.0.0 v7.16.0 labels Oct 15, 2021
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Oct 15, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Copy link
Contributor

@debadair debadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@williamrandolph
Copy link
Contributor Author

Thanks for the approvals! I will coordinate with Gordon to get this merged without snarling up his PR too much.

@williamrandolph williamrandolph added auto-backport-and-merge auto-backport Automatically create backport pull requests when merged and removed auto-backport-and-merge labels Oct 19, 2021
@williamrandolph williamrandolph merged commit 5c6a481 into elastic:master Oct 19, 2021
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
7.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 79302

williamrandolph added a commit to williamrandolph/elasticsearch that referenced this pull request Oct 19, 2021
…status responses (elastic#79302)

* Change 'upgrade' to 'migration' in System Index Migration responses

* Mute rest compatibility test
williamrandolph added a commit that referenced this pull request Oct 19, 2021
…status responses (#79302) (#79495)

* Change 'upgrade' to 'migration' in System Index Migration responses
weizijun added a commit to weizijun/elasticsearch that referenced this pull request Oct 20, 2021
* upstream/master: (24 commits)
  Implement framework for migrating system indices (elastic#78951)
  Improve transient settings deprecation message (elastic#79504)
  Remove getValue and getValues from Field (elastic#79516)
  Store Template's mappings as bytes for disk serialization (elastic#78746)
  [ML] Add queue_capacity setting to start deployment API (elastic#79433)
  [ML] muting rest compat test issue elastic#79518 (elastic#79519)
  Avoid redundant available indices check (elastic#76540)
  Re-enable BWC tests
  TEST Ensure password 14 chars length on Kerberos FIPS tests (elastic#79496)
  [DOCS] Temporarily remove APM links (elastic#79411)
  Fix CCSDuelIT for skipped shards (elastic#79490)
  Add other time accounting in HotThreads (elastic#79392)
  Add deprecation info API entries for deprecated monitoring settings (elastic#78799)
  Add note in breaking changes for nameid_format (elastic#77785)
  Use 'migration' instead of 'upgrade' in GET system feature migration status responses (elastic#79302)
  Upgrade lucene version 8b68bf60c98 (elastic#79461)
  Use Strings#EMPTY_ARRAY (elastic#79452)
  Quicker shared cache file preallocation (elastic#79447)
  [ML] Removing some code that's obsolete for 8.0 (elastic#79444)
  Ensure indexing_data CCR requests are compressed (elastic#79413)
  ...
@williamrandolph williamrandolph deleted the rename-feature-upgrade-to-feature-migration-2 branch May 23, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged :Core/Infra/Core Core issues without another label >non-issue Team:Core/Infra Meta label for core/infra team v7.16.0 v8.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants