-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing name of shards field in node/stats api to shard_stats #78531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticmachine
added
the
Team:Data Management
Meta label for data/management team
label
Sep 30, 2021
Pinging @elastic/es-data-management (Team:Data Management) |
dakrone
approved these changes
Oct 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pinging @elastic/clients-team (Team:Clients) |
olivere
added a commit
to olivere/elastic
that referenced
this pull request
Oct 6, 2021
This commit brings the Nodes Stats API to the latest version. Notice that 7.15.0 has a elastic/elasticsearch#78311 that is likely being fixed by elastic/elasticsearch#78531, so we're skipping the given test for that specific release. Once 7.15.1 is released, the bug might reappear unless the PR is being merged into that version. See #1535
masseyke
added a commit
to masseyke/elasticsearch
that referenced
this pull request
Oct 6, 2021
…ic#78531) If the _nodes/stats API received a level=shards request parameter, then the response would have two "shards" fields, which would cause problems with json parsers. This commit renames the "shards" field that currently only contains "total_count" to "shard_stats". Relates elastic#78311 elastic#75433
masseyke
added a commit
to masseyke/elasticsearch
that referenced
this pull request
Oct 6, 2021
…ic#78531) If the _nodes/stats API received a level=shards request parameter, then the response would have two "shards" fields, which would cause problems with json parsers. This commit renames the "shards" field that currently only contains "total_count" to "shard_stats". Relates elastic#78311 elastic#75433
masseyke
added a commit
that referenced
this pull request
Oct 6, 2021
…#78803) If the _nodes/stats API received a level=shards request parameter, then the response would have two "shards" fields, which would cause problems with json parsers. This commit renames the "shards" field that currently only contains "total_count" to "shard_stats". Relates #78311 #75433 #78531
masseyke
added a commit
that referenced
this pull request
Oct 7, 2021
…#78806) If the _nodes/stats API received a level=shards request parameter, then the response would have two "shards" fields, which would cause problems with json parsers. This commit renames the "shards" field that currently only contains "total_count" to "shard_stats". Relates #78311 #75433 #78531
wjp719
added a commit
to wjp719/elasticsearch
that referenced
this pull request
Oct 7, 2021
…' into feature/data_stream_support_routing * wjp/feature/data_stream_support_routing: (44 commits) Revert "Adjust /_cat/templates not to request all metadata (elastic#78812)" Allow indices lookup to be built lazily (elastic#78745) [DOCS] Document default security in alpha2 (elastic#78227) Add cluster applier stats (elastic#77552) Fix failing URLDecodeProcessorTests::testProcessor test (elastic#78690) Upgrade to lucene snapshot ba75dc5e6bf (elastic#78817) Adjust /_cat/templates not to request all metadata (elastic#78812) Simplify build plugin license handling (elastic#77009) Fix SearchableSnapshotsBlobStoreCacheIntegTests.testBlobStoreCache (elastic#78616) Improve Docker image caching and testing (elastic#78552) Load knn vectors format with mmapfs (elastic#78724) Fix date math zone test to use negative minutes (elastic#78796) Changing name of shards field in node/stats api to shard_stats (elastic#78531) [DOCS] Fix system index refs in restore tutorial (elastic#78582) Add previously removed settings back for 8.0 (elastic#78784) TSDB: Fix template name in test Add a system property to forcibly format everything (elastic#78768) Revert "Adding config so that some tests will break if over-the-wire encryption fails (elastic#78409)" (elastic#78787) Must date math test failure Adding config so that some tests will break if over-the-wire encryption fails (elastic#78409) ...
masseyke
added a commit
that referenced
this pull request
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Data Management/Stats
Statistics tracking and retrieval APIs
Team:Clients
Meta label for clients team
Team:Data Management
Meta label for data/management team
v7.15.1
v7.16.0
v8.0.0-beta1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the _nodes/stats API received a level=shards request parameter, then the response would have two "shards" fields,
which would cause problems with json parsers. This commit renames the "shards" field that currently only contains
"total_count" to "shard_stats".
Relates #78311 #75433