Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding shard count to node stats api #75433

Merged

Conversation

masseyke
Copy link
Member

Added a shards section to each node returned by the _node/stats api. Currently it only contains a count of shards

masseyke added 2 commits July 16, 2021 12:18
Added a shards section to each node returned by the node stats api. Currently it only contains a count of shards
@sethmlarson sethmlarson added the Team:Clients Meta label for clients team label Jul 16, 2021
@masseyke masseyke added :Data Management/Stats Statistics tracking and retrieval APIs >enhancement Team:Data Management Meta label for data/management team v7.15.0 labels Jul 19, 2021
@masseyke masseyke requested a review from dakrone July 19, 2021 21:07
@masseyke
Copy link
Member Author

This replaces an older PR at #75395

@masseyke masseyke linked an issue Jul 19, 2021 that may be closed by this pull request
@masseyke masseyke marked this pull request as ready for review July 20, 2021 13:56
@elasticmachine
Copy link
Collaborator

Pinging @elastic/clients-team (Team:Clients)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (Team:Core/Features)

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left two semi-minor comments

@masseyke
Copy link
Member Author

@elasticmachine update branch

@masseyke
Copy link
Member Author

@elasticmachine update branch

@masseyke masseyke merged commit ddc3b37 into elastic:master Jul 27, 2021
@masseyke masseyke deleted the feature/total-shard-count-in-node-stats branch July 27, 2021 15:41
masseyke added a commit that referenced this pull request Jul 28, 2021
Backporting _nodes/stats feature

This commit cherry-picks the commit from #75433, and changes it to apply to 7.15 and later.
@jakelandis
Copy link
Contributor

closes #75052

ywangd pushed a commit to ywangd/elasticsearch that referenced this pull request Jul 30, 2021
* Adding shard count to _nodes/stats api

Added a shards section to each node returned by the _nodes/stats api. Currently this new section only contains a total count of all shards on the node.
masseyke added a commit that referenced this pull request Oct 6, 2021
If the _nodes/stats API received a level=shards request parameter, then the response would have two "shards" fields,
which would cause problems with json parsers. This commit renames the "shards" field that currently only contains
"total_count" to "shard_stats".
Relates #78311 #75433
masseyke added a commit to masseyke/elasticsearch that referenced this pull request Oct 6, 2021
…ic#78531)

If the _nodes/stats API received a level=shards request parameter, then the response would have two "shards" fields,
which would cause problems with json parsers. This commit renames the "shards" field that currently only contains
"total_count" to "shard_stats".
Relates elastic#78311 elastic#75433
masseyke added a commit to masseyke/elasticsearch that referenced this pull request Oct 6, 2021
…ic#78531)

If the _nodes/stats API received a level=shards request parameter, then the response would have two "shards" fields,
which would cause problems with json parsers. This commit renames the "shards" field that currently only contains
"total_count" to "shard_stats".
Relates elastic#78311 elastic#75433
masseyke added a commit that referenced this pull request Oct 6, 2021
…#78803)

If the _nodes/stats API received a level=shards request parameter, then the response would have two "shards" fields,
which would cause problems with json parsers. This commit renames the "shards" field that currently only contains
"total_count" to "shard_stats".
Relates #78311 #75433 #78531
masseyke added a commit that referenced this pull request Oct 7, 2021
…#78806)

If the _nodes/stats API received a level=shards request parameter, then the response would have two "shards" fields,
which would cause problems with json parsers. This commit renames the "shards" field that currently only contains
"total_count" to "shard_stats".
Relates #78311 #75433 #78531
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Stats Statistics tracking and retrieval APIs >enhancement Team:Clients Meta label for clients team Team:Data Management Meta label for data/management team v7.15.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report shard count per node in _nodes/stats
7 participants