-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding shard count to node stats api #75433
Merged
masseyke
merged 11 commits into
elastic:master
from
masseyke:feature/total-shard-count-in-node-stats
Jul 27, 2021
Merged
Adding shard count to node stats api #75433
masseyke
merged 11 commits into
elastic:master
from
masseyke:feature/total-shard-count-in-node-stats
Jul 27, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a shards section to each node returned by the node stats api. Currently it only contains a count of shards
This replaces an older PR at #75395 |
Pinging @elastic/clients-team (Team:Clients) |
Pinging @elastic/es-core-features (Team:Core/Features) |
dakrone
approved these changes
Jul 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I left two semi-minor comments
server/src/test/java/org/elasticsearch/index/shard/SimpleShardStatsTest.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/shard/SimpleShardStats.java
Outdated
Show resolved
Hide resolved
dakrone
reviewed
Jul 26, 2021
server/src/main/java/org/elasticsearch/index/shard/ShardCountStats.java
Outdated
Show resolved
Hide resolved
@elasticmachine update branch |
…masseyke/elasticsearch into feature/total-shard-count-in-node-stats
@elasticmachine update branch |
masseyke
added a commit
that referenced
this pull request
Jul 28, 2021
Backporting _nodes/stats feature This commit cherry-picks the commit from #75433, and changes it to apply to 7.15 and later.
closes #75052 |
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
Jul 30, 2021
* Adding shard count to _nodes/stats api Added a shards section to each node returned by the _nodes/stats api. Currently this new section only contains a total count of all shards on the node.
This was referenced Sep 27, 2021
masseyke
added a commit
to masseyke/elasticsearch
that referenced
this pull request
Oct 6, 2021
…ic#78531) If the _nodes/stats API received a level=shards request parameter, then the response would have two "shards" fields, which would cause problems with json parsers. This commit renames the "shards" field that currently only contains "total_count" to "shard_stats". Relates elastic#78311 elastic#75433
masseyke
added a commit
to masseyke/elasticsearch
that referenced
this pull request
Oct 6, 2021
…ic#78531) If the _nodes/stats API received a level=shards request parameter, then the response would have two "shards" fields, which would cause problems with json parsers. This commit renames the "shards" field that currently only contains "total_count" to "shard_stats". Relates elastic#78311 elastic#75433
masseyke
added a commit
that referenced
this pull request
Oct 6, 2021
…#78803) If the _nodes/stats API received a level=shards request parameter, then the response would have two "shards" fields, which would cause problems with json parsers. This commit renames the "shards" field that currently only contains "total_count" to "shard_stats". Relates #78311 #75433 #78531
masseyke
added a commit
that referenced
this pull request
Oct 7, 2021
…#78806) If the _nodes/stats API received a level=shards request parameter, then the response would have two "shards" fields, which would cause problems with json parsers. This commit renames the "shards" field that currently only contains "total_count" to "shard_stats". Relates #78311 #75433 #78531
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Data Management/Stats
Statistics tracking and retrieval APIs
>enhancement
Team:Clients
Meta label for clients team
Team:Data Management
Meta label for data/management team
v7.15.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a shards section to each node returned by the _node/stats api. Currently it only contains a count of shards