Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always enable soft-deletes in CcrRollingUpgradeIT #76786

Merged
merged 1 commit into from
Aug 20, 2021
Merged

Always enable soft-deletes in CcrRollingUpgradeIT #76786

merged 1 commit into from
Aug 20, 2021

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Aug 20, 2021

Relates #76765

org.elasticsearch.upgrades.CcrRollingUpgradeIT > testUniDirectionalIndexFollowing FAILED
    org.elasticsearch.client.ResponseException: method [PUT], host [http://127.0.0.1:34865], URI [/follower_index3/_ccr/follow?wait_for_active_shards=1], status line [HTTP/1.1 400 Bad Request]
    {"error":{"root_cause":[{"type":"illegal_argument_exception","reason":"leader index [leader_index3] does not have soft deletes enabled. soft deletes must be enabled when the index is created by setting index.soft_deletes.enabled to true"}],"type":"illegal_argument_exception","reason":"leader index [leader_index3] does not have soft deletes enabled. soft deletes must be enabled when the index is created by setting index.soft_deletes.enabled to true"},"status":400}
        at __randomizedtesting.SeedInfo.seed([20A03E90B07D1D3:8E4E96ECDC3CF096]:0)
        at org.elasticsearch.client.RestClient.convertResponse(RestClient.java:326)
        at org.elasticsearch.client.RestClient.performRequest(RestClient.java:296)
        at org.elasticsearch.client.RestClient.performRequest(RestClient.java:270)
        at org.elasticsearch.upgrades.CcrRollingUpgradeIT.followIndex(CcrRollingUpgradeIT.java:319)
        at org.elasticsearch.upgrades.CcrRollingUpgradeIT.testUniDirectionalIndexFollowing(CcrRollingUpgradeIT.java:73)
REPRODUCE WITH: ./gradlew ':x-pack:qa:rolling-upgrade-multi-cluster:v6.8.19#follower#twoThirdsUpgradedTest' -Dtests.class="org.elasticsearch.upgrades.CcrRollingUpgradeIT" -Dtests.method="testUniDirectionalIndexFollowing" -Dtests.seed=20A03E90B07D1D3 -Dtests.bwc=true -Dtests.locale=es-CO -Dtests.timezone=Jamaica -Druntime.java=8

@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests :Distributed Indexing/CCR Issues around the Cross Cluster State Replication features auto-backport Automatically create backport pull requests when merged v7.16.0 v7.15.1 labels Aug 20, 2021
@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Aug 20, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@dnhatn dnhatn mentioned this pull request Aug 20, 2021
Merged
@arteam
Copy link
Contributor

arteam commented Aug 20, 2021

Thanks @dnhatn! I will rebase #76779 after this change gets merged

@arteam
Copy link
Contributor

arteam commented Aug 20, 2021

@elasticsearchmachine run elasticsearch-ci/bwc

@arteam
Copy link
Contributor

arteam commented Aug 20, 2021

@elasticsearchmachine run elasticsearch-ci/packaging-tests-windows-sample

1 similar comment
@arteam
Copy link
Contributor

arteam commented Aug 20, 2021

@elasticsearchmachine run elasticsearch-ci/packaging-tests-windows-sample

@arteam
Copy link
Contributor

arteam commented Aug 20, 2021

@elasticsearchmachine run elasticsearch-ci/bwc

@dnhatn dnhatn added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Aug 20, 2021
@elasticsearchmachine elasticsearchmachine merged commit 1317119 into elastic:7.x Aug 20, 2021
@dnhatn dnhatn deleted the 7x-enable-soft-deletes branch August 20, 2021 23:16
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Aug 20, 2021
@dnhatn
Always enable soft-deletes in CcrRollingUpgradeIT (elastic#76786)
9fa8ed5
@dnhatn dnhatn mentioned this pull request Aug 20, 2021
Merged
elasticsearchmachine pushed a commit that referenced this pull request Aug 21, 2021
@dnhatn
Always enable soft-deletes in CcrRollingUpgradeIT (#76797)
5412228 
* Remove AwaitsFix CcrRollingUpgradeIT (#76765)

Fixed in #60054

* Always enable soft-deletes in CcrRollingUpgradeIT (#76786)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arteam arteam arteam approved these changes

Assignees
No one assigned
Labels
auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed Indexing/CCR Issues around the Cross Cluster State Replication features Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test Issues or PRs that are addressing/adding tests v7.15.1 v7.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dnhatn @elasticmachine @arteam @elasticsearchmachine