Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AwaitsFix in CcrRollingUpgradeIT #76765

Merged
merged 1 commit into from
Aug 20, 2021

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Aug 20, 2021

Fixed in #60054

@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests :Distributed Indexing/CCR Issues around the Cross Cluster State Replication features auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) v7.16.0 labels Aug 20, 2021
@elasticmachine elasticmachine added the Team:Distributed Meta label for distributed team (obsolete) label Aug 20, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

Copy link
Contributor

@henningandersen henningandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I think we would want to backport this to 7.15 branch too just for completeness?

@dnhatn dnhatn added v7.15.1 auto-backport Automatically create backport pull requests when merged labels Aug 20, 2021
@dnhatn
Copy link
Member Author

dnhatn commented Aug 20, 2021

I think we would want to backport this to 7.15 branch too just for completeness?

Yes, I have relabelled it.


}

@AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/59625")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to enable only this test or all of them? There's a couple of @AwaitsFix annotations left in CcrRollingUpgradeIT all pointing to the same Github issue.

@elasticsearchmachine elasticsearchmachine merged commit bd038d7 into elastic:7.x Aug 20, 2021
arteam added a commit to arteam/elasticsearch that referenced this pull request Aug 20, 2021
@dnhatn dnhatn deleted the 7x-unmute-ccr branch August 20, 2021 18:56
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Aug 20, 2021
elasticsearchmachine pushed a commit that referenced this pull request Aug 21, 2021
* Remove AwaitsFix CcrRollingUpgradeIT (#76765)

Fixed in #60054

* Always enable soft-deletes in CcrRollingUpgradeIT (#76786)
arteam added a commit that referenced this pull request Aug 22, 2021
* Remove all @AwaitsFix CcrRollingUpgradeIT

See #76765 and #60054

* Use the wait_for_active_shards adopted from ES 8

* Update CcrRollingUpgradeIT.java

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed Indexing/CCR Issues around the Cross Cluster State Replication features Team:Distributed Meta label for distributed team (obsolete) >test Issues or PRs that are addressing/adding tests v7.15.1 v7.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants