Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update redline library to 1.2.10 #76440

Merged
merged 2 commits into from
Aug 13, 2021
Merged

Update redline library to 1.2.10 #76440

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
678b0fe
Update redline library to 1.2.10
breskeby Aug 12, 2021
7126891
Update common about enforcing redline 1.2.10
breskeby Aug 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions distribution/packages/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,22 +48,18 @@ buildscript {
maven { url 'https://jitpack.io' }
}

// We rely on a patched version of the redline library used to build rpm packages
// We rely on a specific version of the redline library used to build rpm packages
// to support sha256header in our elasticsearch RPMs
// TODO: Update / remove this dependency once https://github.com/craigwblake/redline/pull/157 got merged
// Be aware that it seems the redline project hasnt been active for a while
// TODO: Remove once https://github.com/nebula-plugins/gradle-ospackage-plugin/pull/402 got merged and released
configurations.all {
resolutionStrategy {
dependencySubstitution {
substitute module('org.redline-rpm:redline') using module('com.github.breskeby:redline:9c85270')
}
force 'org.redline-rpm:redline:1.2.10'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come we force it? Does Gradle ship its own, or something like that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what that means is that we enforce a particular version (1.2.10). Otherwise redline 1.2.9 would be brought in as a transitive dependency by the nebula.ospackage plugin that has 1.2.9 declared. (There's an open PR on ospackage to fix this).

}
}

dependencies {
classpath "com.github.breskeby:gradle-ospackage-plugin:98455c1"
}

}

apply plugin: "nebula.ospackage-base"
Expand Down