Update redline library to 1.2.10 #76440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breskeby
added
:Delivery/Build
mark-vieira
approved these changes
Aug 12, 2021
distribution/packages/build.gradle
Outdated
| @@ -54,9 +54,7 @@ buildscript { | |||
| // Be aware that it seems the redline project hasnt been active for a while | |||
There was a problem hiding this comment.
Can we remove this comment? 😉
pugnascotia
reviewed
Aug 12, 2021
| dependencySubstitution { | ||
| substitute module('org.redline-rpm:redline') using module('com.github.breskeby:redline:9c85270') | ||
| } | ||
| force 'org.redline-rpm:redline:1.2.10' |
There was a problem hiding this comment.
How come we force it? Does Gradle ship its own, or something like that?
There was a problem hiding this comment.
what that means is that we enforce a particular version (1.2.10). Otherwise redline 1.2.9 would be brought in as a transitive dependency by the nebula.ospackage plugin that has 1.2.9 declared. (There's an open PR on ospackage to fix this).
|
Pinging @elastic/es-delivery (Team:Delivery) |
pugnascotia
approved these changes
Aug 13, 2021
The redline team just released version 1.2.10 of the redline library which contains our fix of the rpm signatures / headers. Also a PR to update that dependency in the ospackage plugin has been raised at nebula-plugins/gradle-ospackage-plugin#402
breskeby
force-pushed
the
update-redline-version
branch
from
e708a0e to
7126891
Compare
💚 Backport successful
|
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Aug 13, 2021
* Update redline library to 1.2.10 The redline team just released version 1.2.10 of the redline library which contains our fix of the rpm signatures / headers. Also a PR to update that dependency in the ospackage plugin has been raised at nebula-plugins/gradle-ospackage-plugin#402 * Update common about enforcing redline 1.2.10
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 13, 2021
* Update redline library to 1.2.10 The redline team just released version 1.2.10 of the redline library which contains our fix of the rpm signatures / headers. Also a PR to update that dependency in the ospackage plugin has been raised at nebula-plugins/gradle-ospackage-plugin#402 * Update common about enforcing redline 1.2.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The redline team just released version 1.2.10 of the redline
library which contains our fix of the rpm signatures / headers.
Also a PR to update that dependency in the ospackage plugin has been
raised at nebula-plugins/gradle-ospackage-plugin#402