Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Fix null pointer exception after all datafeed indices deleted #76401

Merged
merged 3 commits into from
Aug 12, 2021
Merged

[ML] Fix null pointer exception after all datafeed indices deleted #76401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d3cbf5
[ML] Fix null pointer exception after all datafeed indices deleted
droberts195 Aug 12, 2021
ef14153
Fix for rollups
droberts195 Aug 12, 2021
d3e7cf3
Readjust unit tests since zero hits is possible with rollups
droberts195 Aug 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions ...main/java/org/elasticsearch/xpack/ml/datafeed/extractor/chunked/ChunkedDataExtractor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
*/
public class ChunkedDataExtractor implements DataExtractor {

private interface DataSummary {
interface DataSummary {
long estimateChunk();
boolean hasData();
long earliestTime();
Expand Down Expand Up @@ -209,11 +209,11 @@ private DataSummary newScrolledDataSummary() {
LOGGER.debug("[{}] Scrolling Data summary response was obtained", context.jobId);
timingStatsReporter.reportSearchDuration(searchResponse.getTook());

Aggregations aggregations = searchResponse.getAggregations();
long earliestTime = 0;
long latestTime = 0;
long totalHits = searchResponse.getHits().getTotalHits().value;
if (totalHits > 0) {
Aggregations aggregations = searchResponse.getAggregations();
Min min = aggregations.get(EARLIEST_TIME);
earliestTime = (long) min.getValue();
Max max = aggregations.get(LATEST_TIME);
Expand All @@ -231,6 +231,13 @@ private DataSummary newAggregatedDataSummary() {
timingStatsReporter.reportSearchDuration(searchResponse.getTook());

Aggregations aggregations = searchResponse.getAggregations();
// This can happen if all the indices the datafeed is searching are deleted after it started.
// Note that unlike the scrolled data summary method above we cannot check for this situation
// by checking for zero hits, because aggregations that work on rollups return zero hits even
// when they retrieve data.
if (aggregations == null) {
return AggregatedDataSummary.noDataSummary(context.histogramInterval);
}
Min min = aggregations.get(EARLIEST_TIME);
Max max = aggregations.get(LATEST_TIME);
return new AggregatedDataSummary(min.getValue(), max.getValue(), context.histogramInterval);
Expand Down Expand Up @@ -309,13 +316,18 @@ public boolean hasData() {
}
}

private static class AggregatedDataSummary implements DataSummary {
static class AggregatedDataSummary implements DataSummary {

private final double earliestTime;
private final double latestTime;
private final long histogramIntervalMillis;

private AggregatedDataSummary(double earliestTime, double latestTime, long histogramInterval) {
static AggregatedDataSummary noDataSummary(long histogramInterval) {
// hasData() uses infinity to mean no data
return new AggregatedDataSummary(Double.POSITIVE_INFINITY, Double.POSITIVE_INFINITY, histogramInterval);
}

AggregatedDataSummary(double earliestTime, double latestTime, long histogramInterval) {
this.earliestTime = earliestTime;
this.latestTime = latestTime;
this.histogramIntervalMillis = histogramInterval;
Expand Down
11 changes: 9 additions & 2 deletions ...java/org/elasticsearch/xpack/ml/datafeed/extractor/chunked/ChunkedDataExtractorTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,8 @@ public void testExtractionGivenSpecifiedChunk() throws IOException {
public void testExtractionGivenSpecifiedChunkAndAggs() throws IOException {
chunkSpan = TimeValue.timeValueSeconds(1);
TestDataExtractor extractor = new TestDataExtractor(1000L, 2300L, true, 1000L);
extractor.setNextResponse(createSearchResponse(0L, 1000L, 2200L));
// 0 hits with non-empty data is possible with rollups
extractor.setNextResponse(createSearchResponse(randomFrom(0L, 2L, 10000L), 1000L, 2200L));

InputStream inputStream1 = mock(InputStream.class);
InputStream inputStream2 = mock(InputStream.class);
Expand Down Expand Up @@ -200,7 +201,8 @@ public void testExtractionGivenAutoChunkAndAggs() throws IOException {
chunkSpan = null;
TestDataExtractor extractor = new TestDataExtractor(100_000L, 450_000L, true, 200L);

extractor.setNextResponse(createSearchResponse(0L, 100_000L, 400_000L));
// 0 hits with non-empty data is possible with rollups
extractor.setNextResponse(createSearchResponse(randomFrom(0L, 2L, 10000L), 100_000L, 400_000L));

InputStream inputStream1 = mock(InputStream.class);
InputStream inputStream2 = mock(InputStream.class);
Expand Down Expand Up @@ -504,6 +506,11 @@ public void testDataSummaryRequestIsFailed() {
expectThrows(SearchPhaseExecutionException.class, extractor::next);
}

public void testNoDataSummaryHasNoData() {
ChunkedDataExtractor.DataSummary summary = ChunkedDataExtractor.AggregatedDataSummary.noDataSummary(randomNonNegativeLong());
assertFalse(summary.hasData());
}

private SearchResponse createSearchResponse(long totalHits, long earliestTime, long latestTime) {
SearchResponse searchResponse = mock(SearchResponse.class);
when(searchResponse.status()).thenReturn(RestStatus.OK);
Expand Down