-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Fix null pointer exception after all datafeed indices deleted #76401
Merged
droberts195
merged 3 commits into
elastic:master
from
droberts195:fix_datafeed_npe_when_all_indices_deleted
Aug 12, 2021
Merged
[ML] Fix null pointer exception after all datafeed indices deleted #76401
droberts195
merged 3 commits into
elastic:master
from
droberts195:fix_datafeed_npe_when_all_indices_deleted
Aug 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A datafeed will not start running if no indices exist that match the pattern it's configured to search. However, it is possible that after the datafeed has started somebody could delete all the indices that it is configured to search. This change handles that situation more gracefully, avoiding repeated logging of null pointer exceptions to the Elasticsearch log.
Pinging @elastic/ml-core (Team:ML) |
droberts195
added
the
auto-backport
Automatically create backport pull requests when merged
label
Aug 12, 2021
dimitris-athanasiou
approved these changes
Aug 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
benwtrent
approved these changes
Aug 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was referenced Aug 12, 2021
droberts195
added a commit
to droberts195/elasticsearch
that referenced
this pull request
Aug 12, 2021
…lastic#76401) A datafeed will not start running if no indices exist that match the pattern it's configured to search. However, it is possible that after the datafeed has started somebody could delete all the indices that it is configured to search. This change handles that situation more gracefully, avoiding repeated logging of null pointer exceptions to the Elasticsearch log.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 12, 2021
…76401) (#76406) A datafeed will not start running if no indices exist that match the pattern it's configured to search. However, it is possible that after the datafeed has started somebody could delete all the indices that it is configured to search. This change handles that situation more gracefully, avoiding repeated logging of null pointer exceptions to the Elasticsearch log.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 12, 2021
…76401) (#76407) A datafeed will not start running if no indices exist that match the pattern it's configured to search. However, it is possible that after the datafeed has started somebody could delete all the indices that it is configured to search. This change handles that situation more gracefully, avoiding repeated logging of null pointer exceptions to the Elasticsearch log.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
>bug
:ml
Machine learning
Team:ML
Meta label for the ML team
v7.14.1
v7.15.0
v8.0.0-alpha2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A datafeed will not start running if no indices exist that match
the pattern it's configured to search. However, it is possible that
after the datafeed has started somebody could delete all the indices
that it is configured to search.
This change handles that situation more gracefully, avoiding
repeated logging of null pointer exceptions to the Elasticsearch log.