Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script: Remove FieldAccess #76109

Merged

Conversation

stu-elastic
Copy link
Contributor

Remove FieldAccess inner class from fields api classes
based on changes in #76045

@stu-elastic stu-elastic added :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >refactoring v8.0.0 v7.15.0 labels Aug 4, 2021
@stu-elastic stu-elastic requested a review from jdconrad August 4, 2021 15:48
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Aug 4, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Copy link
Contributor

@jdconrad jdconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stu-elastic stu-elastic merged commit 858cc32 into elastic:master Aug 4, 2021
elasticsearchmachine pushed a commit to elasticsearchmachine/elasticsearch that referenced this pull request Aug 4, 2021
Remove FieldAccess inner class from fields api classes
based on changes in elastic#76045
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
7.x

@mark-vieira mark-vieira added auto-backport Automatically create backport pull requests when merged and removed auto-backport-and-merge labels Aug 4, 2021
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

The backport operation could not be completed due to the following error:
There are no branches to backport to. Aborting.

To backport manually run:
backport --pr 76109

elasticsearchmachine added a commit that referenced this pull request Aug 4, 2021
Remove FieldAccess inner class from fields api classes
based on changes in #76045

Co-authored-by: Stuart Tettemer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >refactoring Team:Core/Infra Meta label for core/infra team v7.15.0 v8.0.0-alpha2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants