Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to allow list instance methods on the script class #76045

Merged
merged 4 commits into from
Aug 3, 2021

Conversation

jdconrad
Copy link
Contributor

@jdconrad jdconrad commented Aug 3, 2021

This change adds support to allow list instance methods on the script class in Painless and super classes of the script class. It works the same way as allow listing works now for other classes.

Example:

Allow list:

class org.elasticsearch.painless.ThisTests$TestThisBaseScript @no_import {
  String baseString();
}


class org.elasticsearch.painless.ThisTests$TestThisScript @no_import { // extends TestThisBaseScript
  String testString();

Script:

baseString() + testString() // 'base' and 'test'

Result:
basetest

@jdconrad jdconrad added >enhancement :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache v8.0.0 auto-backport Automatically create backport pull requests when merged v7.15.0 labels Aug 3, 2021
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Aug 3, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@jdconrad jdconrad requested a review from stu-elastic August 3, 2021 16:28
Copy link
Contributor

@stu-elastic stu-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice.

@jdconrad
Copy link
Contributor Author

jdconrad commented Aug 3, 2021

@stu-elastic Thanks for the review. Will commit as soon as CI passes.

@jdconrad jdconrad merged commit f898c30 into elastic:master Aug 3, 2021
elasticsearchmachine pushed a commit to elasticsearchmachine/elasticsearch that referenced this pull request Aug 3, 2021
…ic#76045)

This change adds support to allow list instance methods on the script class in Painless and super 
classes of the script class. It works the same way as allow listing works now for other classes.
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
7.x

jdconrad pushed a commit that referenced this pull request Aug 3, 2021
… (#76047)

This change adds support to allow list instance methods on the script class in Painless and super 
classes of the script class. It works the same way as allow listing works now for other classes.
stu-elastic added a commit that referenced this pull request Aug 4, 2021
Remove FieldAccess inner class from fields api classes
based on changes in #76045
elasticsearchmachine pushed a commit to elasticsearchmachine/elasticsearch that referenced this pull request Aug 4, 2021
Remove FieldAccess inner class from fields api classes
based on changes in elastic#76045
elasticsearchmachine added a commit that referenced this pull request Aug 4, 2021
Remove FieldAccess inner class from fields api classes
based on changes in #76045

Co-authored-by: Stuart Tettemer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >enhancement Team:Core/Infra Meta label for core/infra team v7.15.0 v8.0.0-alpha2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants