-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to allow list instance methods on the script class #76045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdconrad
added
>enhancement
:Core/Infra/Scripting
Scripting abstractions, Painless, and Mustache
v8.0.0
auto-backport
Automatically create backport pull requests when merged
v7.15.0
labels
Aug 3, 2021
Pinging @elastic/es-core-infra (Team:Core/Infra) |
stu-elastic
approved these changes
Aug 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice.
@stu-elastic Thanks for the review. Will commit as soon as CI passes. |
elasticsearchmachine
pushed a commit
to elasticsearchmachine/elasticsearch
that referenced
this pull request
Aug 3, 2021
…ic#76045) This change adds support to allow list instance methods on the script class in Painless and super classes of the script class. It works the same way as allow listing works now for other classes.
💚 Backport successful
|
jdconrad
pushed a commit
that referenced
this pull request
Aug 3, 2021
… (#76047) This change adds support to allow list instance methods on the script class in Painless and super classes of the script class. It works the same way as allow listing works now for other classes.
stu-elastic
added a commit
that referenced
this pull request
Aug 4, 2021
Remove FieldAccess inner class from fields api classes based on changes in #76045
elasticsearchmachine
pushed a commit
to elasticsearchmachine/elasticsearch
that referenced
this pull request
Aug 4, 2021
Remove FieldAccess inner class from fields api classes based on changes in elastic#76045
elasticsearchmachine
added a commit
that referenced
this pull request
Aug 4, 2021
Remove FieldAccess inner class from fields api classes based on changes in #76045 Co-authored-by: Stuart Tettemer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
:Core/Infra/Scripting
Scripting abstractions, Painless, and Mustache
>enhancement
Team:Core/Infra
Meta label for core/infra team
v7.15.0
v8.0.0-alpha2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support to allow list instance methods on the script class in Painless and super classes of the script class. It works the same way as allow listing works now for other classes.
Example:
Allow list:
Script:
Result:
basetest