[Test] Mute more certificate tests on JDK8 u292 #75994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JDK 1.8.0_292 has a race condition that sometimes causes the PBEWithSHA1AndDESede algorithm to appear as unavailable. This change mutes additional tests on this JDK build Relates: elastic#75952, elastic#75571, elastic#75718
tvernum
added
:Security/TLS
|
Pinging @elastic/es-security (Team:Security) |
ywangd
approved these changes
Aug 3, 2021
| @@ -419,6 +418,9 @@ public void testGeneratingSignedPemCertificates() throws Exception { | |||
| } | |||
|
|
|||
| public void testHandleLongPasswords() throws Exception { | |||
| assumeFalse("JDK bug JDK-8266279, https://github.com/elastic/elasticsearch/issues/75571", | |||
There was a problem hiding this comment.
Should the linked issue be #75952? Or are you using a single issue to track them all? Might be worthwhile to close all others if this is the case. But since the mute is specific to a particular version, I think we can just close the issues.
There was a problem hiding this comment.
I think it's better to link them all to a single issue. Perhaps we should go back and change the description of the issue.
Tracking them in multiple issues makes it harder to handle once the next JDK build comes out and they all start failing (because the bug wasn't fixed) or we can remove these checks (if it is fixed).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JDK 1.8.0_292 has a race condition that sometimes causes the
PBEWithSHA1AndDESede algorithm to appear as unavailable.
This change mutes additional tests on this JDK build
Relates: #75952, #75571, #75718