-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mute some security tests on problematic JDK8 build #75718
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds some `assumeFalse` (or modifies exising ones) to mute tests on JDK 1.8.0_292 due to JDK-8266279 On this JDK build, a race condition sometimes causes the PBEWithSHA1AndDESede algorithm to appear as though it is unavailable. Relates: elastic#75571, elastic#75417, elastic#75379, elastic#72639, elastic#72359
Pinging @elastic/es-security (Team:Security) |
ywangd
approved these changes
Jul 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tvernum
added a commit
to tvernum/elasticsearch
that referenced
this pull request
Jul 27, 2021
This commit adds some `assumeFalse` (or modifies exising ones) to mute tests on JDK 1.8.0_292 due to JDK-8266279 On this JDK build, a race condition sometimes causes the PBEWithSHA1AndDESede algorithm to appear as though it is unavailable. Relates: elastic#75571, elastic#75417, elastic#75379, elastic#72639, elastic#72359 Backport of: elastic#75718
tvernum
added a commit
that referenced
this pull request
Jul 27, 2021
This commit adds some `assumeFalse` (or modifies exising ones) to mute tests on JDK 1.8.0_292 due to JDK-8266279 On this JDK build, a race condition sometimes causes the PBEWithSHA1AndDESede algorithm to appear as though it is unavailable. Relates: #75571, #75417, #75379, #72639, #72359 Backport of: #75718
tvernum
added a commit
to tvernum/elasticsearch
that referenced
this pull request
Jul 28, 2021
This commit adds some `assumeFalse` (or modifies exising ones) to mute tests on JDK 1.8.0_292 due to JDK-8266279 On this JDK build, a race condition sometimes causes the PBEWithSHA1AndDESede algorithm to appear as though it is unavailable. Relates: elastic#75571, elastic#75417, elastic#75379, elastic#72639, elastic#72359 Backport of: elastic#75718
tvernum
added a commit
to tvernum/elasticsearch
that referenced
this pull request
Jul 28, 2021
This commit adds some `assumeFalse` (or modifies exising ones) to mute tests on JDK 1.8.0_292 due to JDK-8266279 On this JDK build, a race condition sometimes causes the PBEWithSHA1AndDESede algorithm to appear as though it is unavailable. Relates: elastic#75571, elastic#75417, elastic#75379, elastic#72639, elastic#72359 Backport of: elastic#75718
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 28, 2021
* Mute some security tests on problematic JDK8 build This commit adds some `assumeFalse` (or modifies exising ones) to mute tests on JDK 1.8.0_292 due to JDK-8266279 On this JDK build, a race condition sometimes causes the PBEWithSHA1AndDESede algorithm to appear as though it is unavailable. Relates: #75571, #75417, #75379, #72639, #72359 Backport of: #75718 * Fix import
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 28, 2021
This commit adds some `assumeFalse` (or modifies exising ones) to mute tests on JDK 1.8.0_292 due to JDK-8266279 On this JDK build, a race condition sometimes causes the PBEWithSHA1AndDESede algorithm to appear as though it is unavailable. Relates: #75571, #75417, #75379, #72639, #72359 Backport of: #75718
tvernum
added a commit
to tvernum/elasticsearch
that referenced
this pull request
Aug 3, 2021
JDK 1.8.0_292 has a race condition that sometimes causes the PBEWithSHA1AndDESede algorithm to appear as unavailable. This change mutes additional tests on this JDK build Relates: elastic#75952, elastic#75571, elastic#75718
tvernum
added a commit
that referenced
this pull request
Aug 3, 2021
jkakavas
added a commit
to jkakavas/elasticsearch
that referenced
this pull request
Feb 15, 2022
We had muted specifc tests that were hit by JDK-8266279, by not allowing the tests to run on Java 1.8.0_292. We have since upgraded our Java 8 version in CI to Java 1.8.0_301 so the muting is irrelevant and can be removed Resolves elastic#75571, elastic#75417, elastic#75379, elastic#72639, elastic#72359, elastic#75952, elastic#75718
jkakavas
added a commit
to jkakavas/elasticsearch
that referenced
this pull request
Feb 15, 2022
We had muted specific tests that were hit by JDK-8266279, by not allowing the tests to run on Java 1.8.0_292. We have since upgraded our Java 8 version in CI to Java 1.8.0_301 so the muting is irrelevant and can be removed Resolves elastic#75571, elastic#75417, elastic#75379, elastic#72639, elastic#72359, elastic#75952, elastic#75718
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
:Security/Security
Security issues without another label
Team:Security
Meta label for security team
>test-mute
Use for PR that only mute tests
v6.8.18
v7.13.5
v7.14.0
v7.15.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds some
assumeFalse
(or modifies exising ones) to mutetests on JDK 1.8.0_292 due to JDK-8266279
On this JDK build, a race condition sometimes causes the
PBEWithSHA1AndDESede algorithm to appear as though it is unavailable.
Relates: #75571, #75417, #75379, #72639, #72359