Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resurrect _xpack/monitoring routes #75948

Merged
merged 2 commits into from
Aug 5, 2021
Merged

Resurrect _xpack/monitoring routes #75948

merged 2 commits into from
Aug 5, 2021

Conversation

joegallo
Copy link
Contributor

@joegallo joegallo commented Aug 2, 2021 •
edited
Loading

Related to #51816 / #68905.

Adds back the _xpack/monitoring routes when using rest compatibility for a request.

@joegallo joegallo force-pushed the resurrect-xpack-monitoring-routes branch from b5ad71a to e05b5be Compare August 5, 2021 01:49
@joegallo
Copy link
Contributor Author

joegallo commented Aug 5, 2021 •
edited
Loading

Note: the _monitoring/bulk rest tests are all muted on master and 7.x (see #70280), so I couldn't do the usual rewriting in build.gradle -- so this is just a smoketest to make sure the endpoint exists and accepts docs, nothing fancy.

@joegallo joegallo added the Team:Clients Meta label for clients team label Aug 5, 2021
@joegallo
Copy link
Contributor Author

joegallo commented Aug 5, 2021

See #73930 (comment) re: Team:Clients -- I don't think there's anything the clients team needs to do here.

@joegallo joegallo marked this pull request as ready for review August 5, 2021 01:52
@elasticmachine
Copy link
Collaborator

Pinging @elastic/clients-team (Team:Clients)

@joegallo joegallo requested review from jakelandis and pgomulka August 5, 2021 01:55
pgomulka
pgomulka approved these changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@pgomulka pgomulka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joegallo joegallo merged commit 5a97262 into elastic:master Aug 5, 2021
@joegallo joegallo deleted the resurrect-xpack-monitoring-routes branch August 5, 2021 13:25
joegallo added a commit that referenced this pull request Aug 5, 2021
@joegallo
Revert "Re-enable deprecated _xpack/monitoring routes via REST compat…
26b41f2 
…ibility (#75948)"

This reverts commit 5a97262.
@joegallo joegallo restored the resurrect-xpack-monitoring-routes branch August 5, 2021 13:49
@joegallo
Copy link
Contributor Author

joegallo commented Aug 5, 2021

Blargh. master failed after this, so I reverted it. I'll come back again once I figure out why this worked on my branch/pr but not on master. 😬

@joegallo joegallo deleted the resurrect-xpack-monitoring-routes branch August 5, 2021 14:51
@joegallo joegallo mentioned this pull request Aug 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgomulka pgomulka pgomulka approved these changes

@jakelandis jakelandis Awaiting requested review from jakelandis

Assignees
No one assigned
Labels
>non-issue Team:Clients Meta label for clients team v8.0.0-alpha2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joegallo @elasticmachine @pgomulka @jakelandis @elasticsearchmachine