Resurrect _xpack/license routes #73930
Conversation
|
Pinging @elastic/clients-team (Team:Clients) |
|
I don't think this will impact the client's team. When the |
| task.replaceKeyInDo("license.post_start_basic", "xpack-license.post_start_basic") | ||
| task.replaceKeyInDo("license.post_start_trial", "xpack-license.post_start_trial") | ||
|
|
||
| task.addAllowedWarningRegex(".*_xpack/license.* is deprecated.*") |
There was a problem hiding this comment.
should this be allowed or just warnings ? I think we can require it since the modified spec only has the deprecated variant.
There was a problem hiding this comment.
Ooh, good point. I'll check!
There was a problem hiding this comment.
Alright, I looked into this for a little while, and I don't think just warnings ends up working very well for this, at least as it's currently written.
It requires a test name (see the InjectWarnings constructor), which works well enough on its own, but we also (sometimes) need to allow warnings on the do sections within setup or teardown, and that happens to end up being the case here.
That's not to say that we couldn't rework the machinery a bit to make that possible, but it's more than just a tweak on this PR.
Related to #51816 / #68905.
Adds back the
_xpack/licenseroutes when using rest compatibility for a request.