Resolve date math expressions before looking up index metadata #75314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danhermann
added
>bug
:Data Management/Ingest Node
elasticmachine
added
the
Team:Data Management
|
Pinging @elastic/es-core-features (Team:Core/Features) |
dakrone
reviewed
Jul 13, 2021
|
|
||
| // index name matches with IDM: | ||
| IndexRequest indexRequest = new IndexRequest("<idx-{now/d}>"); | ||
| boolean result = IngestService.resolvePipelines(indexRequest, indexRequest, metadata); |
There was a problem hiding this comment.
I believe this will very rarely fail when the first call to System.currentTimeMillis() on line 1382 is called on one day, then this is called on the next day (across the day delineation I mean).
Is it worth adding a parameter that allows overriding the time used when resolving for this test? (I only say since we've had failures related to this with data streams and dates in index names)
There was a problem hiding this comment.
Yep, worth it. Added in b934eb4
|
Thanks, @dakrone! |
masseyke
pushed a commit
to masseyke/elasticsearch
that referenced
this pull request
Jul 16, 2021
danhermann
added a commit
to danhermann/elasticsearch
that referenced
this pull request
Jul 19, 2021
danhermann
added a commit
that referenced
this pull request
Jul 19, 2021
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
Jul 30, 2021
danhermann
added a commit
to danhermann/elasticsearch
that referenced
this pull request
Aug 5, 2021
danhermann
added a commit
that referenced
this pull request
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is somewhat similar to #69727 except that in this case, the final pipeline is set directly on an existing index rather than in a template. The root cause of the issue was looking for the ingest pipelines on index metadata before resolving any date math expressions in the index name.
Fixes #75047