-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Templates match indices with date math expressions #71433
Merged
danhermann
merged 3 commits into
elastic:master
from
danhermann:69727_fix_final_pipeline
Apr 8, 2021
Merged
Templates match indices with date math expressions #71433
danhermann
merged 3 commits into
elastic:master
from
danhermann:69727_fix_final_pipeline
Apr 8, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danhermann
added
>bug
:Data Management/Ingest Node
Execution or management of Ingest Pipelines including GeoIP
v8.0.0
v7.13.0
v7.12.1
labels
Apr 7, 2021
Pinging @elastic/es-core-features (Team:Core/Features) |
@elasticmachine update branch |
dakrone
approved these changes
Apr 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks, @dakrone! |
danhermann
added a commit
to danhermann/elasticsearch
that referenced
this pull request
Apr 12, 2021
@danhermann Looks like we're good to remove |
danhermann
added a commit
to danhermann/elasticsearch
that referenced
this pull request
Apr 20, 2021
danhermann
added a commit
that referenced
this pull request
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>bug
:Data Management/Ingest Node
Execution or management of Ingest Pipelines including GeoIP
Team:Data Management
Meta label for data/management team
v7.12.1
v7.13.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root cause of the bug identified in #69727 (reported independently by several users) is that the
findV?Templates
methods inMetadataIndexTemplateService
do not resolve index names with date math expressions before attempting to match them. The reproduction scenario in #69727 demonstrates one flavor of this problem. Before 7.9, an ingest pipeline with a date_index_name processor would (accidentally) work around that problem, but the simple statement below would fail to execute the final pipeline in any ES version (assuming a template that defines a final pipeline for an index pattern oftest-*
):A change to the way ingest pipelines work in 7.9 caused the date_index_name scenario to fail as well. This change resolves both problems.
Fixes #69727.