Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs that composite agg no longer uses global ords #74754

Merged
merged 1 commit into from
Jul 5, 2021

Conversation

ywelsch
Copy link
Contributor

@ywelsch ywelsch commented Jun 30, 2021

Follow-up to #74559

@ywelsch ywelsch added >docs General docs changes :Analytics/Aggregations Aggregations v8.0.0 v7.14.0 labels Jun 30, 2021
@ywelsch ywelsch requested review from not-napoleon and jimczi June 30, 2021 14:20
@elasticmachine elasticmachine added Team:Docs Meta label for docs team Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Jun 30, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@ywelsch
Copy link
Contributor Author

ywelsch commented Jul 5, 2021

@mark-vieira why replace the label for 7.14.0 by 7.15.0 and not 7.14.1?

@ywelsch ywelsch merged commit 412ac1a into elastic:master Jul 5, 2021
ywelsch added a commit that referenced this pull request Jul 5, 2021
ywelsch added a commit that referenced this pull request Jul 5, 2021
@mark-vieira
Copy link
Contributor

@mark-vieira why replace the label for 7.14.0 by 7.15.0 and not 7.14.1?

I honestly don't remember. 😂

not-napoleon added a commit to not-napoleon/elasticsearch that referenced this pull request Oct 7, 2021
not-napoleon added a commit to not-napoleon/elasticsearch that referenced this pull request Oct 7, 2021
not-napoleon added a commit that referenced this pull request Oct 7, 2021
* Revert "Update docs that composite agg no longer uses global ords (#74754)"

This reverts commit ec799ab.

* Revert "Avoid global ordinals in composite aggregation (#74559)"

This reverts commit 5cfcb2f.

 Conflicts:
	server/src/main/java/org/elasticsearch/search/aggregations/bucket/composite/CompositeValuesCollectorQueue.java
	server/src/main/java/org/elasticsearch/search/aggregations/bucket/composite/OrdinalValuesSource.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations >docs General docs changes Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Docs Meta label for docs team v7.14.0 v7.15.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants