Avoid global ordinals in composite aggregation #74559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
not-napoleon
approved these changes
Jun 28, 2021
...va/org/elasticsearch/search/aggregations/bucket/composite/CompositeValuesCollectorQueue.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/elasticsearch/search/aggregations/bucket/composite/OrdinalValuesSource.java
Show resolved
Hide resolved
...rc/main/java/org/elasticsearch/search/aggregations/bucket/composite/OrdinalValuesSource.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/elasticsearch/search/aggregations/bucket/composite/OrdinalValuesSource.java
Outdated
Show resolved
Hide resolved
jimczi
reviewed
Jun 29, 2021
...rc/main/java/org/elasticsearch/search/aggregations/bucket/composite/OrdinalValuesSource.java
Outdated
Show resolved
Hide resolved
...va/org/elasticsearch/search/aggregations/bucket/composite/CompositeValuesCollectorQueue.java
Outdated
Show resolved
Hide resolved
CompositeValuesCollectorQueueTests.testRandom was timing out as it took too long to run, because we kept checking the invariant every time on copyCurrent
ywelsch
added a commit
that referenced
this pull request
Jun 29, 2021
A composite aggregation on a keyword field requires global ordinals today to ensure fast comparisons between segments. It only needs to keep track of the top N composite buckets, however. Since N is typically small, we can just use the segment ordinal for comparison when collecting inside a segment and remap ordinals when we go to the next segment. Closes #47452
ywelsch
added a commit
that referenced
this pull request
Jul 5, 2021
ywelsch
added a commit
that referenced
this pull request
Jul 5, 2021
ywelsch
added a commit
that referenced
this pull request
Jul 5, 2021
ywelsch
added a commit
that referenced
this pull request
Aug 2, 2021
probakowski
pushed a commit
to probakowski/elasticsearch
that referenced
this pull request
Aug 2, 2021
Adds release highlights for match_only_text (elastic#66172) and more memory-efficient composite aggregations (elastic#74559).
not-napoleon
added a commit
to not-napoleon/elasticsearch
that referenced
this pull request
Oct 7, 2021
This reverts commit 5cfcb2f. Conflicts: server/src/main/java/org/elasticsearch/search/aggregations/bucket/composite/CompositeValuesCollectorQueue.java server/src/main/java/org/elasticsearch/search/aggregations/bucket/composite/OrdinalValuesSource.java server/src/main/java/org/elasticsearch/search/aggregations/bucket/composite/TermsValuesSourceBuilder.java server/src/test/java/org/elasticsearch/search/aggregations/bucket/composite/SingleDimensionValuesSourceTests.java
not-napoleon
added a commit
to not-napoleon/elasticsearch
that referenced
this pull request
Oct 7, 2021
This reverts commit 5cfcb2f. Conflicts: server/src/main/java/org/elasticsearch/search/aggregations/bucket/composite/CompositeValuesCollectorQueue.java server/src/main/java/org/elasticsearch/search/aggregations/bucket/composite/OrdinalValuesSource.java
not-napoleon
added a commit
that referenced
this pull request
Oct 7, 2021
* Revert "Update docs that composite agg no longer uses global ords (#74754)" This reverts commit ec799ab. * Revert "Avoid global ordinals in composite aggregation (#74559)" This reverts commit 5cfcb2f. Conflicts: server/src/main/java/org/elasticsearch/search/aggregations/bucket/composite/CompositeValuesCollectorQueue.java server/src/main/java/org/elasticsearch/search/aggregations/bucket/composite/OrdinalValuesSource.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Composite aggregations can paginate all buckets from a multi-level aggregation efficiently. It is heavily used by the transform functionality, for example to convert existing Elasticsearch indices into entity-centric indices that summarize the behavior of users or sessions.
Composite aggregations on
keywordfields used global ordinals (see "What are global ordinals") to ensure fast comparisons between segments. Global ordinals on high cardinality fields can however use a lot of heap memory as part of the field data cache.With this PR, composite aggregations no longer need global ordinals, reducing resource consumption for batch-like jobs such as transform. The trick is that composite aggregations only need to keep track of the top N composite buckets. Since N is typically small, we can just use the segment ordinal for comparison when collecting inside a segment and remap ordinals when we go to the next segment.
Closes #47452