Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rest Api Compatibility] Allow for type in geo shape query #74553

Merged
merged 6 commits into from
Jun 30, 2021
Merged

[Rest Api Compatibility] Allow for type in geo shape query #74553

merged 6 commits into from
Jun 30, 2021

Conversation

pgomulka
Copy link
Contributor

@pgomulka pgomulka commented Jun 24, 2021 •
edited
Loading

Allowing to specify type in geo_shape query. previously removed by #47792
types removal compatible meta #54160
main meta issue #51816

@pgomulka pgomulka changed the title geo typed shape draft [Rest Api Compatibility] Allow for type in geo shape query Jun 28, 2021
@pgomulka pgomulka self-assigned this Jun 28, 2021
@pgomulka pgomulka added :Core/Infra/REST API REST infrastructure and utilities v8.0.0 labels Jun 28, 2021
@pgomulka pgomulka marked this pull request as ready for review June 28, 2021 13:13
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Jun 28, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@pgomulka pgomulka requested a review from romseygeek June 28, 2021 13:14
@pgomulka pgomulka mentioned this pull request Jun 28, 2021
Closed
66 tasks
@romseygeek
Copy link
Contributor

I'm curious, do we not have existing YAML tests that exercise this in 7x?

@pgomulka
Copy link
Contributor Author

I could not find any. Also the PR that removed the support for it did not modify/removed any of the yaml tests

romseygeek
romseygeek approved these changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pgomulka pgomulka merged commit 4fa1c8d into elastic:master Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romseygeek romseygeek romseygeek approved these changes

Assignees
No one assigned
Labels
:Core/Infra/REST API REST infrastructure and utilities >enhancement Team:Core/Infra Meta label for core/infra team v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pgomulka @elasticmachine @romseygeek @jakelandis