Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove types from GeoShapeQueryBuilder #47792

Merged
merged 6 commits into from
Oct 23, 2019
Merged

Remove types from GeoShapeQueryBuilder #47792

merged 6 commits into from
Oct 23, 2019

Conversation

romseygeek
Copy link
Contributor

This commit removes the unused 'shapeType' information from AbstractGeoQueryBuilder
and its implementations.

Related to #41059

@romseygeek romseygeek added :Analytics/Geo Indexing, search aggregations of geo points and shapes >refactoring v8.0.0 labels Oct 9, 2019
@romseygeek romseygeek self-assigned this Oct 9, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (:Analytics/Geo)

@jpountz jpountz mentioned this pull request Oct 9, 2019
Closed
66 tasks
@romseygeek
Copy link
Contributor Author

@elasticmachine update branch

@cbuescher cbuescher self-assigned this Oct 21, 2019
@romseygeek
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/packaging-sample-matrix

cbuescher
cbuescher approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a comment regarding leaving/modifying javadoc. Change and leave or ignore, I'm fine either way.

server/src/main/java/org/elasticsearch/index/query/GeoShapeQueryBuilder.java
* @param indexedShapeType
* Index type of the indexed Shapes
* @deprecated use {@link #GeoShapeQueryBuilder(String, String)} instead
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe keep and adapt the docs? Or do you think its not useful or self-explanatory?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this back in, had removed it by mistake. Thanks!

@romseygeek romseygeek merged commit 0ed05a9 into elastic:master Oct 23, 2019
@romseygeek romseygeek mentioned this pull request Oct 29, 2019
Merged
@pgomulka pgomulka mentioned this pull request Mar 25, 2020
Closed
66 tasks
@pgomulka pgomulka mentioned this pull request Jun 28, 2021
Merged
pgomulka added a commit that referenced this pull request Jun 30, 2021
@pgomulka
[Rest Api Compatibility] Allow for type in geo shape query (#74553)
4fa1c8d 
Allowing to specify type in geo_shape query. previously removed by #47792
types removal compatible meta #54160
main meta issue #51816
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbuescher cbuescher cbuescher approved these changes

@jpountz jpountz Awaiting requested review from jpountz

@nknize nknize Awaiting requested review from nknize

@iverase iverase Awaiting requested review from iverase

Assignees

@romseygeek romseygeek

@cbuescher cbuescher

Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >refactoring v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@romseygeek @elasticmachine @cbuescher @jakelandis