-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable query cache for FunctionScoreQuery and ScriptScoreQuery #74060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit disables the query cache for the `FunctionScoreQuery` and the `ScriptScoreQuery`. These queries are not meant to be cached. If the score is not needed, we'll now cache the sub-query and filters independently since we don't want to keep an unused script in the cache. Closes elastic#73925
jimczi
added
>bug
:Search/Search
Search-related issues that do not fall into other categories
v8.0.0
v7.14.0
v7.13.2
labels
Jun 14, 2021
Pinging @elastic/es-search (Team:Search) |
romseygeek
approved these changes
Jun 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jimczi
added a commit
that referenced
this pull request
Jun 16, 2021
This commit disables the query cache for the `FunctionScoreQuery` and the `ScriptScoreQuery`. These queries are not meant to be cached. If the score is not needed, we'll now cache the sub-query and filters independently since we don't want to keep an unused script in the cache. Closes #73925
jimczi
added a commit
that referenced
this pull request
Jun 16, 2021
This commit disables the query cache for the `FunctionScoreQuery` and the `ScriptScoreQuery`. These queries are not meant to be cached. If the score is not needed, we'll now cache the sub-query and filters independently since we don't want to keep an unused script in the cache. Closes #73925
limingnihao
pushed a commit
to limingnihao/elasticsearch
that referenced
this pull request
Jun 17, 2021
* master: (284 commits) [DOCS] Update central reporting image (elastic#74195) [DOCS] SQL: Document `null` handing for string functions (elastic#74201) Fix Snapshot Docs Listing Query Params in Body Incorrectly (elastic#74196) [DOCS] EQL: Note EQL uses `fields` parameter (elastic#74194) Mute failing MixedClusterClientYamlTestSuiteIT test {p0=indices.split/20_source_mapping/Split index ignores target template mapping} test (elastic#74198) Cleanup Duplicate Constants in Snapshot XContent Params (elastic#74114) [DOC] Add watcher to the threadpool doc (elastic#73935) [Rest Api Compatibility] Validate Query typed api (elastic#74171) Replace deprecated `script.cache.*` settings with `script.context.$constext.cache_*` in documentation. (elastic#74144) Pin Alpine Linux version in Docker builds (elastic#74169) Fix clone API settings docs bug (elastic#74175) [ML] refactor internal datafeed management (elastic#74018) Disable query cache for FunctionScoreQuery and ScriptScoreQuery (elastic#74060) Fork the sending of file chunks during recovery (elastic#74164) RuntimeField.Builder should not extend FieldMapper.Builder (elastic#73840) Run CheckIndex on metadata index before loading (elastic#73239) Deprecate setting version on analyzers (elastic#74073) Add test with null transform id in stats request (elastic#74130) Order imports when reformatting (elastic#74059) Move deprecation code from xpack core to deprecation module. (elastic#74120) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>bug
:Search/Search
Search-related issues that do not fall into other categories
Team:Search
Meta label for search team
v7.13.3
v7.14.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit disables the query cache for the
FunctionScoreQuery
and theScriptScoreQuery
. These queries are not meant to be cached. If the scoreis not needed, we'll now cache the sub-query and filters independently since
we don't want to keep an unused script in the cache.
Closes #73925