Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] refactor internal datafeed management #74018

Merged

Conversation

benwtrent
Copy link
Member

This unifies the concept of object management between datafeeds and anomaly jobs.

@elasticmachine elasticmachine added the Team:ML Meta label for the ML team label Jun 10, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@benwtrent
Copy link
Member Author

Dear reviewer:

DatafeedRunner is the old DatafeedManager. Its a simple rename refactor.

The DatafeedManager is a brand new class that pulls in methods that were originally inside Transport* classes.

@benwtrent benwtrent force-pushed the refactor/ml-df-refactor-internal-crud branch from cc7bfeb to 5fe2c33 Compare June 14, 2021 17:15
Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactoring, CI is green LGTM!

@benwtrent benwtrent merged commit a5adc7d into elastic:master Jun 16, 2021
@benwtrent benwtrent deleted the refactor/ml-df-refactor-internal-crud branch June 16, 2021 12:06
benwtrent added a commit that referenced this pull request Jun 16, 2021
This unifies the concept of object management between datafeeds and anomaly jobs.
limingnihao pushed a commit to limingnihao/elasticsearch that referenced this pull request Jun 17, 2021
* master: (284 commits)
  [DOCS] Update central reporting image (elastic#74195)
  [DOCS] SQL: Document `null` handing for string functions (elastic#74201)
  Fix Snapshot Docs Listing Query Params in Body Incorrectly (elastic#74196)
  [DOCS] EQL: Note EQL uses `fields` parameter (elastic#74194)
  Mute failing MixedClusterClientYamlTestSuiteIT test {p0=indices.split/20_source_mapping/Split index ignores target template mapping} test (elastic#74198)
  Cleanup Duplicate Constants in Snapshot XContent Params (elastic#74114)
  [DOC] Add watcher to the threadpool doc (elastic#73935)
  [Rest Api Compatibility] Validate Query typed api (elastic#74171)
  Replace deprecated `script.cache.*` settings with `script.context.$constext.cache_*` in documentation. (elastic#74144)
  Pin Alpine Linux version in Docker builds (elastic#74169)
  Fix clone API settings docs bug (elastic#74175)
  [ML] refactor internal datafeed management (elastic#74018)
  Disable query cache for FunctionScoreQuery and ScriptScoreQuery (elastic#74060)
  Fork the sending of file chunks during recovery (elastic#74164)
  RuntimeField.Builder should not extend FieldMapper.Builder (elastic#73840)
  Run CheckIndex on metadata index before loading (elastic#73239)
  Deprecate setting version on analyzers (elastic#74073)
  Add test with null transform id in stats request (elastic#74130)
  Order imports when reformatting (elastic#74059)
  Move deprecation code from xpack core to deprecation module. (elastic#74120)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml Machine learning >non-issue Team:ML Meta label for the ML team v7.14.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants