Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate multiple path.data entries #71207

Merged
merged 6 commits into from
Apr 2, 2021
Merged

Deprecate multiple path.data entries #71207

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dcb4c2a
Deprecate multiple path.data entries
rjernst Apr 1, 2021
dadb7f0
tweak wording
rjernst Apr 1, 2021
8133db5
Filtered warnings
jasontedor Apr 2, 2021
eb5081e
cleanup
rjernst Apr 2, 2021
b36b05d
Remove accidental file
rjernst Apr 2, 2021
02cbad2
fix imports
rjernst Apr 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions server/src/main/java/org/elasticsearch/node/Node.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,13 @@ protected Node(final Environment initialEnvironment,
Build.CURRENT.getQualifiedVersion());
}

if (initialEnvironment.dataFiles().length > 1) {
// NOTE: we use initialEnvironment here, but assertEquivalent below ensures the data paths do not change
deprecationLogger.deprecate(DeprecationCategory.SETTINGS, "multiple-data-paths",
"Configuring multiple path.data paths is deprecated. Use RAID-0 or other system level features for utilizing" +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I should have thought of this when you ran this wording by me earlier. I think we should avoid "RAID0" here specifically, and simply say RAID, so that it doesn't seem like we're putting our weight behind a specific RAID configuration.

"multiple disks. This feature will be removed in 8.0.");
}

if (logger.isDebugEnabled()) {
logger.debug("using config [{}], data [{}], logs [{}], plugins [{}]",
initialEnvironment.configFile(), Arrays.toString(initialEnvironment.dataFiles()),
Expand Down