Deprecate multiple path.data entries #71207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a node level deprecation log message when multiple data paths are specified. relates elastic#71205
rjernst
added
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
jasontedor
reviewed
Apr 1, 2021
| if (initialEnvironment.dataFiles().length > 1) { | ||
| // NOTE: we use initialEnvironment here, but assertEquivalent below ensures the data paths do not change | ||
| deprecationLogger.deprecate(DeprecationCategory.SETTINGS, "multiple-data-paths", | ||
| "Configuring multiple path.data paths is deprecated. Use RAID-0 or other system level features for utilizing" + |
There was a problem hiding this comment.
Sorry, I should have thought of this when you ran this wording by me earlier. I think we should avoid "RAID0" here specifically, and simply say RAID, so that it doesn't seem like we're putting our weight behind a specific RAID configuration.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Apr 2, 2021
This commit adds a node level deprecation log message when multiple data paths are specified. relates elastic#71205
rjernst
added a commit
that referenced
this pull request
Apr 2, 2021
pgomulka
added a commit
to pgomulka/elasticsearch
that referenced
this pull request
Jun 2, 2021
EnsureNoWarnings method should assert that there is no other warnings than the allowed "predefined" warnings in filteredWarnings() method bug introduced in elastic#71207
pgomulka
added a commit
that referenced
this pull request
Jun 2, 2021
EnsureNoWarnings method should assert that there is no other warnings than the allowed "predefined" warnings in filteredWarnings() method bug introduced in #71207
pgomulka
added a commit
to pgomulka/elasticsearch
that referenced
this pull request
Jun 2, 2021
EnsureNoWarnings method should assert that there is no other warnings than the allowed "predefined" warnings in filteredWarnings() method bug introduced in elastic#71207
pgomulka
added a commit
that referenced
this pull request
Jun 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a node level deprecation log message when multiple
data paths are specified.
relates #71205