-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix document field generation for vnd_cbor and vnd_smile #67020
Fix document field generation for vnd_cbor and vnd_smile #67020
Conversation
there is a special case for creating expected value for Floats when xcontentType is CBOR or SMILE closes elastic#67009 closes elastic#67018
Pinging @elastic/es-core-infra (Team:Core/Infra) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you unmute the test I muted too? See a0c090a.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (with un-muting comment as David mentioned)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM2 (empirically at least, I've no idea why this fixes anything but can confirm that it does)
@DaveCTurner |
there is a special case for creating expected value for Floats when
xcontentType is CBOR or SMILE
closes #67009
closes #67018
gradle check
?