Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix document field generation for vnd_cbor and vnd_smile #67020

Conversation

pgomulka
Copy link
Contributor

@pgomulka pgomulka commented Jan 5, 2021

there is a special case for creating expected value for Floats when
xcontentType is CBOR or SMILE

closes #67009
closes #67018

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

there is a special case for creating expected value for Floats when
xcontentType is CBOR or SMILE

closes elastic#67009
closes elastic#67018
@pgomulka pgomulka added >test Issues or PRs that are addressing/adding tests :Core/Infra/Core Core issues without another label labels Jan 5, 2021
@pgomulka pgomulka self-assigned this Jan 5, 2021
@pgomulka pgomulka requested review from dakrone and removed request for leehinman January 5, 2021 16:45
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Jan 5, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you unmute the test I muted too? See a0c090a.

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (with un-muting comment as David mentioned)

@pgomulka pgomulka requested a review from DaveCTurner January 5, 2021 17:05
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2 (empirically at least, I've no idea why this fixes anything but can confirm that it does)

@pgomulka
Copy link
Contributor Author

pgomulka commented Jan 5, 2021

@DaveCTurner
the problem was with random test data generation. Looks like there is a special logic to handle Float data types for cbor and smile. Previously we only had one XcontentType (i.e. XContentType.CBOR) per each XContent (i.e. CborXContent)
Now we also have versioned XContentTypes (think of this as an allowed media type) like VND_CBOR - application/vnd.elasticsearch+cbor. This also uses CborXContent so should be included into this conditional test data generation logic.
Let me know if this clarifies a little

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests
Projects
None yet
4 participants