Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetResultsTests#testToAndFromXContentEmbedded fails reproducibly #67009

Closed
DaveCTurner opened this issue Jan 5, 2021 · 4 comments · Fixed by #67020
Closed

GetResultsTests#testToAndFromXContentEmbedded fails reproducibly #67009

DaveCTurner opened this issue Jan 5, 2021 · 4 comments · Fixed by #67020
Labels
:Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team >test-failure Triaged test failures from CI

Comments

@DaveCTurner
Copy link
Contributor

Build scan:

Not available, only seen locally.

Repro line:

./gradlew :server:test --tests "org.elasticsearch.index.get.GetResultTests.testToAndFromXContentEmbedded" -Dtests.seed=3205E115CC20EB17 -Dtests.locale=pl-PL -Dtests.timezone=EST -Druntime.java=14

Reproduces locally?:

Yes, 100%.

Applicable branches:

master (a904c70)

Failure history:

Not seen in CI

Failure excerpt:

org.elasticsearch.index.get.GetResultTests > testToAndFromXContentEmbedded FAILED
    java.lang.AssertionError: expected: org.elasticsearch.index.get.GetResult<{
      "_index" : null,
      "_id" : null,
      "_seq_no" : 6646957961986097284,
      "_primary_term" : 7,
      "_routing" : "zEne",
      "found" : true,
      "_source" : {
        "lARIVmJe" : -8033289809137462302,
        "gjHzQtFcg" : [
          {
            "gffbiDUCb" : "HSoJwgpi",
            "sIBprepwOS" : 0.4510828074110138,
            "LDaaGAMJEW" : "dsZUiS",
            "VhULAmxZo" : 0.24047737661153457,
            "cQMWfNK" : "WQIzxlgRO"
          }
        ]
      },
      "fields" : {
        "ogBeX" : [
          {
            "wMFIY" : true,
            "Aglsj" : "KzFHPZmZed",
            "JjSfA" : 2022698992
          }
        ],
        "HnuSo" : [
          [
            -994235075
          ]
        ],
        "GCVqkHMBYi" : [
          -9,
          57,
          37,
          -87
        ],
        "KroFx" : [
          [
            -1732302012,
            -1883312517,
            -1367228499
          ],
          [
            921807463
          ],
          [
            -1791885005,
            1461412019
          ]
        ],
        "TByBh" : [
          0.86527264,
          0.8043281
        ]
      }
    }> but was: org.elasticsearch.index.get.GetResult<{
      "_index" : null,
      "_id" : null,
      "_seq_no" : 6646957961986097284,
      "_primary_term" : 7,
      "_routing" : "zEne",
      "found" : true,
      "_source" : {
        "lARIVmJe" : -8033289809137462302,
        "gjHzQtFcg" : [
          {
            "gffbiDUCb" : "HSoJwgpi",
            "sIBprepwOS" : 0.4510828074110138,
            "LDaaGAMJEW" : "dsZUiS",
            "VhULAmxZo" : 0.24047737661153457,
            "cQMWfNK" : "WQIzxlgRO"
          }
        ]
      },
      "fields" : {
        "ogBeX" : [
          {
            "wMFIY" : true,
            "Aglsj" : "KzFHPZmZed",
            "JjSfA" : 2022698992
          }
        ],
        "HnuSo" : [
          [
            -994235075
          ]
        ],
        "GCVqkHMBYi" : [
          -9,
          57,
          37,
          -87
        ],
        "KroFx" : [
          [
            -1732302012,
            -1883312517,
            -1367228499
          ],
          [
            921807463
          ],
          [
            -1791885005,
            1461412019
          ]
        ],
        "TByBh" : [
          0.86527264,
          0.8043281
        ]
      }
    }>
        at __randomizedtesting.SeedInfo.seed([3205E115CC20EB17:626C2A5B9F6A3F6F]:0)
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.failNotEquals(Assert.java:834)
        at org.junit.Assert.assertEquals(Assert.java:118)
        at org.junit.Assert.assertEquals(Assert.java:144)
        at org.elasticsearch.index.get.GetResultTests.testToAndFromXContentEmbedded(GetResultTests.java:120)

In case it's not obvious, 0.86527264 is a Float in one object and a Double in the other 😬 .

Test was added for the HLRC in #22586 so I'm labelling this to match.

@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Jan 5, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (Team:Core/Features)

DaveCTurner added a commit that referenced this issue Jan 5, 2021
@DaveCTurner
Copy link
Contributor Author

Muted in a0c090a.

@romseygeek
Copy link
Contributor

Seems to have started failing after #65500 was committed, cc @pgomulka

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

pgomulka added a commit to pgomulka/elasticsearch that referenced this issue Jan 5, 2021
there is a special case for creating expected value for Floats when
xcontentType is CBOR or SMILE

closes elastic#67009
closes elastic#67018
pgomulka added a commit that referenced this issue Jan 5, 2021
there is a special case for creating expected value for Floats when
xcontentType is CBOR or SMILE

closes #67009
closes #67018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team >test-failure Triaged test failures from CI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants